Merge pull request #652 from Wikid82/hotfix/ci

fix: simplify Playwright browser installation steps
Merge branch 'main' into hotfix/ci
2026-02-04 12:10:19 -05:00 · 2026-02-04 12:09:37 -05:00 · 2026-02-04 17:08:30 +00:00 · 2026-02-04 11:46:27 -05:00 · 2026-02-04 11:46:17 -05:00 · 2026-02-04 16:44:47 +00:00
1 changed files with 6 additions and 27 deletions
--- a/.github/workflows/e2e-tests-split.yml
+++ b/.github/workflows/e2e-tests-split.yml
@@ -121,7 +121,7 @@ jobs:
    if: |
      (github.event_name != 'workflow_dispatch') ||
      (github.event.inputs.browser == 'chromium' || github.event.inputs.browser == 'all')
-    timeout-minutes: 30
+    timeout-minutes: 45
    env:
      CHARON_EMERGENCY_TOKEN: ${{ secrets.CHARON_EMERGENCY_TOKEN }}
      CHARON_EMERGENCY_SERVER_ENABLED: "true"
@@ -200,14 +200,7 @@ jobs:
      - name: Install dependencies
        run: npm ci

-      - name: Cache Playwright browsers
-        id: playwright-cache
-        uses: actions/cache@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5
-        with:
-          path: ~/.cache/ms-playwright
-          key: playwright-chromium-${{ hashFiles('package-lock.json') }}
-
-      - name: Install & verify Playwright Chromium
+      - name: Install Playwright Chromium
        run: npx playwright install --with-deps chromium

      - name: Run Chromium tests (Shard ${{ matrix.shard }}/${{ matrix.total-shards }})
@@ -284,7 +277,7 @@ jobs:
    if: |
      (github.event_name != 'workflow_dispatch') ||
      (github.event.inputs.browser == 'firefox' || github.event.inputs.browser == 'all')
-    timeout-minutes: 30
+    timeout-minutes: 45
    env:
      CHARON_EMERGENCY_TOKEN: ${{ secrets.CHARON_EMERGENCY_TOKEN }}
      CHARON_EMERGENCY_SERVER_ENABLED: "true"
@@ -363,14 +356,7 @@ jobs:
      - name: Install dependencies
        run: npm ci

-      - name: Cache Playwright browsers
-        id: playwright-cache
-        uses: actions/cache@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5
-        with:
-          path: ~/.cache/ms-playwright
-          key: playwright-firefox-${{ hashFiles('package-lock.json') }}
-
-      - name: Install & verify Playwright Firefox
+      - name: Install Playwright Firefox
        run: npx playwright install --with-deps firefox

      - name: Run Firefox tests (Shard ${{ matrix.shard }}/${{ matrix.total-shards }})
@@ -447,7 +433,7 @@ jobs:
    if: |
      (github.event_name != 'workflow_dispatch') ||
      (github.event.inputs.browser == 'webkit' || github.event.inputs.browser == 'all')
-    timeout-minutes: 30
+    timeout-minutes: 45
    env:
      CHARON_EMERGENCY_TOKEN: ${{ secrets.CHARON_EMERGENCY_TOKEN }}
      CHARON_EMERGENCY_SERVER_ENABLED: "true"
@@ -526,14 +512,7 @@ jobs:
      - name: Install dependencies
        run: npm ci

-      - name: Cache Playwright browsers
-        id: playwright-cache
-        uses: actions/cache@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5
-        with:
-          path: ~/.cache/ms-playwright
-          key: playwright-webkit-${{ hashFiles('package-lock.json') }}
-
-      - name: Install & verify Playwright WebKit
+      - name: Install Playwright WebKit
        run: npx playwright install --with-deps webkit

      - name: Run WebKit tests (Shard ${{ matrix.shard }}/${{ matrix.total-shards }})
Author	SHA1	Message	Date
Jeremy	e56e7656d9	Merge pull request #652 from Wikid82/hotfix/ci fix: simplify Playwright browser installation steps	2026-02-04 12:10:19 -05:00
Jeremy	64f37ba7aa	Merge branch 'main' into hotfix/ci	2026-02-04 12:09:37 -05:00
GitHub Actions	6e3fcf7824	fix: simplify Playwright browser installation steps Remove overly complex verification logic that was causing all browser jobs to fail. Browser installation should fail fast and clearly if there are issues. Changes: - Remove multi-line verification scripts from all 3 browser install steps - Simplify to single command: npx playwright install --with-deps {browser} - Let install step show actual errors if it fails - Let test execution show "browser not found" errors if install incomplete Rationale: - Previous complex verification (using grep/find) was the failure point - Simpler approach provides clearer error messages for debugging - Tests themselves will fail clearly if browsers aren't available Expected outcome: - Install steps show actual error messages if they fail - If install succeeds, tests execute normally - If install "succeeds" but browser is missing, test step shows clear error Timeout remains at 45 minutes (accommodates 10-15 min install + execution)	2026-02-04 17:08:30 +00:00
Jeremy	d626c7d8b3	Merge pull request #650 from Wikid82/hotfix/ci fix: resolve Playwright browser executable not found errors in CI	2026-02-04 11:46:27 -05:00
Jeremy	b34f96aeeb	Merge branch 'main' into hotfix/ci	2026-02-04 11:46:17 -05:00
GitHub Actions	3c0b9fa2b1	fix: resolve Playwright browser executable not found errors in CI Root causes: 1. Browser cache was restoring corrupted/stale binaries from previous runs 2. 30-minute timeout insufficient for fresh Playwright installation (10-15 min) plus Docker/health checks and test execution Changes: - Remove browser caching from all 3 browser jobs (chromium, firefox, webkit) - Increase timeout from 30 → 45 minutes for all jobs - Add diagnostic logging to browser install steps: * Install start/completion timestamps * Exit code verification * Cache directory inspection on failure * Browser executable verification using 'npx playwright test --list' Benefits: - Fresh browser installations guaranteed (no cache pollution) - 15-minute buffer prevents premature timeouts - Detailed diagnostics to catch future installation issues early - Consistent behavior across all browsers Technical notes: - Browser install with --with-deps takes 10-15 minutes per browser - GitHub Actions cache was causing more harm than benefit (stale binaries) - Sequential execution (1 shard per browser) combined with fresh installs ensures stable, reproducible CI behavior Expected outcome: - Firefox/WebKit failures from missing browser executables → resolved - Chrome timeout at 30 minutes → resolved with 45 minute buffer - Future installation issues → caught immediately via diagnostics Refs: #hofix/ci QA: YAML syntax validated, pre-commit hooks passed (12/12)	2026-02-04 16:44:47 +00:00