akanealw/Charon
1
0
Fork 0
Code Issues Pull Requests Actions 16 Packages Projects Releases Wiki Activity

fix: simplify Playwright browser installation steps

Browse Source 
Remove overly complex verification logic that was causing all browser
jobs to fail. Browser installation should fail fast and clearly if
there are issues.

Changes:
- Remove multi-line verification scripts from all 3 browser install steps
- Simplify to single command: npx playwright install --with-deps {browser}
- Let install step show actual errors if it fails
- Let test execution show "browser not found" errors if install incomplete

Rationale:
- Previous complex verification (using grep/find) was the failure point
- Simpler approach provides clearer error messages for debugging
- Tests themselves will fail clearly if browsers aren't available

Expected outcome:
- Install steps show actual error messages if they fail
- If install succeeds, tests execute normally
- If install "succeeds" but browser is missing, test step shows clear error

Timeout remains at 45 minutes (accommodates 10-15 min install + execution)
This commit is contained in:
GitHub Actions
2026-02-04 17:08:30 +00:00
parent b34f96aeeb
commit 6e3fcf7824
1 changed files with 6 additions and 69 deletions
Download Patch File Download Diff File Expand all files Collapse all files

75
.github/workflows/e2e-tests-split.yml vendored
View File

@@ -200,29 +200,8 @@ jobs:
- name: Install dependencies
run: npm ci
- name: Install & verify Playwright Chromium
run: |
echo "⏳ Installing Playwright Chromium (with system dependencies)..."
echo "Start: $(date -u +'%Y-%m-%dT%H:%M:%SZ')"
npx playwright install --with-deps chromium
INSTALL_EXIT=$?
echo "Install exit code: $INSTALL_EXIT"
if [ $INSTALL_EXIT -ne 0 ]; then
echo "::error::Playwright Chromium installation failed"
echo "Cache contents:"
ls -la ~/.cache/ms-playwright/ || echo "Cache directory empty"
exit 1
fi
echo "✅ Verifying Chromium executable..."
if npx playwright test --list --project=chromium 2>&1 | grep -q "Chromium"; then
echo "✅ Chromium executable verified"
else
echo "::error::Chromium executable not found after installation"
exit 1
fi
echo "Completion: $(date -u +'%Y-%m-%dT%H:%M:%SZ')"
- name: Install Playwright Chromium
run: npx playwright install --with-deps chromium
- name: Run Chromium tests (Shard ${{ matrix.shard }}/${{ matrix.total-shards }})
run: |
@@ -377,29 +356,8 @@ jobs:
- name: Install dependencies
run: npm ci
- name: Install & verify Playwright Firefox
run: |
echo "⏳ Installing Playwright Firefox (with system dependencies)..."
echo "Start: $(date -u +'%Y-%m-%dT%H:%M:%SZ')"
npx playwright install --with-deps firefox
INSTALL_EXIT=$?
echo "Install exit code: $INSTALL_EXIT"
if [ $INSTALL_EXIT -ne 0 ]; then
echo "::error::Playwright Firefox installation failed"
echo "Cache contents:"
ls -la ~/.cache/ms-playwright/ || echo "Cache directory empty"
exit 1
fi
echo "✅ Verifying Firefox executable..."
if npx playwright test --list --project=firefox 2>&1 | grep -q "Firefox"; then
echo "✅ Firefox executable verified"
else
echo "::error::Firefox executable not found after installation"
exit 1
fi
echo "Completion: $(date -u +'%Y-%m-%dT%H:%M:%SZ')"
- name: Install Playwright Firefox
run: npx playwright install --with-deps firefox
- name: Run Firefox tests (Shard ${{ matrix.shard }}/${{ matrix.total-shards }})
run: |
@@ -554,29 +512,8 @@ jobs:
- name: Install dependencies
run: npm ci
- name: Install & verify Playwright WebKit
run: |
echo "⏳ Installing Playwright WebKit (with system dependencies)..."
echo "Start: $(date -u +'%Y-%m-%dT%H:%M:%SZ')"
npx playwright install --with-deps webkit
INSTALL_EXIT=$?
echo "Install exit code: $INSTALL_EXIT"
if [ $INSTALL_EXIT -ne 0 ]; then
echo "::error::Playwright WebKit installation failed"
echo "Cache contents:"
ls -la ~/.cache/ms-playwright/ || echo "Cache directory empty"
exit 1
fi
echo "✅ Verifying WebKit executable..."
if npx playwright test --list --project=webkit 2>&1 | grep -q "WebKit"; then
echo "✅ WebKit executable verified"
else
echo "::error::WebKit executable not found after installation"
exit 1
fi
echo "Completion: $(date -u +'%Y-%m-%dT%H:%M:%SZ')"
- name: Install Playwright WebKit
run: npx playwright install --with-deps webkit
- name: Run WebKit tests (Shard ${{ matrix.shard }}/${{ matrix.total-shards }})
run: |