Files
caddy-proxy-manager/tests/unit/api-routes/certificates.test.ts
fuomag9 d9806e84e6 fix: resolve lint and typecheck errors in API routes and tests
- Remove unused imports (users, and) from api-tokens model
- Fix password_hash destructure lint error in user routes
- Fix apiErrorResponse mock pattern in all 12 test files (use instanceof)
- Remove stale eslint-disable directives from test files
- Add eslint override for tests (no-explicit-any, no-require-imports)
- Fix unused vars in settings and tokens tests
- Fix unused tokenB in integration test

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-26 10:33:47 +01:00

259 lines
9.1 KiB
TypeScript

import { describe, it, expect, vi, beforeEach } from 'vitest';
vi.mock('@/src/lib/models/certificates', () => ({
listCertificates: vi.fn(),
createCertificate: vi.fn(),
getCertificate: vi.fn(),
updateCertificate: vi.fn(),
deleteCertificate: vi.fn(),
}));
vi.mock('@/src/lib/api-auth', () => {
const ApiAuthError = class extends Error {
status: number;
constructor(msg: string, status: number) { super(msg); this.status = status; this.name = 'ApiAuthError'; }
};
return {
requireApiAdmin: vi.fn().mockResolvedValue({ userId: 1, role: 'admin', authMethod: 'bearer' }),
requireApiUser: vi.fn().mockResolvedValue({ userId: 1, role: 'admin', authMethod: 'bearer' }),
apiErrorResponse: vi.fn((error: unknown) => {
const { NextResponse: NR } = require('next/server');
if (error instanceof ApiAuthError) {
return NR.json({ error: error.message }, { status: error.status });
}
return NR.json({ error: error instanceof Error ? error.message : 'Internal server error' }, { status: 500 });
}),
ApiAuthError,
};
});
import { GET as listGET, POST } from '@/app/api/v1/certificates/route';
import { GET as getGET, PUT, DELETE } from '@/app/api/v1/certificates/[id]/route';
import { listCertificates, createCertificate, getCertificate, updateCertificate, deleteCertificate } from '@/src/lib/models/certificates';
import { requireApiAdmin } from '@/src/lib/api-auth';
const mockList = vi.mocked(listCertificates);
const mockCreate = vi.mocked(createCertificate);
const mockGet = vi.mocked(getCertificate);
const mockUpdate = vi.mocked(updateCertificate);
const mockDelete = vi.mocked(deleteCertificate);
const mockRequireApiAdmin = vi.mocked(requireApiAdmin);
function createMockRequest(options: { method?: string; body?: unknown } = {}): any {
return {
headers: { get: () => null },
method: options.method ?? 'GET',
nextUrl: { pathname: '/api/v1/certificates', searchParams: new URLSearchParams() },
json: async () => options.body ?? {},
};
}
const sampleCert = {
id: 1,
domains: ['secure.example.com'],
type: 'acme',
status: 'active',
expires_at: '2027-01-01',
created_at: '2026-01-01',
};
beforeEach(() => {
vi.clearAllMocks();
mockRequireApiAdmin.mockResolvedValue({ userId: 1, role: 'admin', authMethod: 'bearer' });
});
describe('GET /api/v1/certificates', () => {
it('returns list of certificates', async () => {
mockList.mockResolvedValue([sampleCert] as any);
const response = await listGET(createMockRequest());
const data = await response.json();
expect(response.status).toBe(200);
expect(data).toEqual([sampleCert]);
});
it('returns 401 on auth failure', async () => {
const { ApiAuthError } = await import('@/src/lib/api-auth');
mockRequireApiAdmin.mockRejectedValue(new ApiAuthError('Unauthorized', 401));
const response = await listGET(createMockRequest());
expect(response.status).toBe(401);
});
});
describe('POST /api/v1/certificates', () => {
it('creates a certificate and returns 201', async () => {
const body = { domains: ['new.example.com'], type: 'acme' };
mockCreate.mockResolvedValue({ id: 2, ...body } as any);
const response = await POST(createMockRequest({ method: 'POST', body }));
const data = await response.json();
expect(response.status).toBe(201);
expect(data.id).toBe(2);
expect(mockCreate).toHaveBeenCalledWith(body, 1);
});
});
describe('GET /api/v1/certificates/[id]', () => {
it('returns a certificate by id', async () => {
mockGet.mockResolvedValue(sampleCert as any);
const response = await getGET(createMockRequest(), { params: Promise.resolve({ id: '1' }) });
const data = await response.json();
expect(response.status).toBe(200);
expect(data).toEqual(sampleCert);
});
it('returns 404 for non-existent certificate', async () => {
mockGet.mockResolvedValue(null as any);
const response = await getGET(createMockRequest(), { params: Promise.resolve({ id: '999' }) });
const data = await response.json();
expect(response.status).toBe(404);
expect(data.error).toBe('Not found');
});
});
describe('PUT /api/v1/certificates/[id]', () => {
it('updates a certificate', async () => {
const body = { domains: ['updated.example.com'] };
mockUpdate.mockResolvedValue({ ...sampleCert, domains: ['updated.example.com'] } as any);
const response = await PUT(createMockRequest({ method: 'PUT', body }), { params: Promise.resolve({ id: '1' }) });
const data = await response.json();
expect(response.status).toBe(200);
expect(data.domains).toEqual(['updated.example.com']);
expect(mockUpdate).toHaveBeenCalledWith(1, body, 1);
});
it('returns 500 when certificate not found', async () => {
mockUpdate.mockRejectedValue(new Error('not found'));
const response = await PUT(createMockRequest({ method: 'PUT', body: { domains: ['x.com'] } }), { params: Promise.resolve({ id: '999' }) });
const data = await response.json();
expect(response.status).toBe(500);
expect(data.error).toBe('not found');
});
});
describe('DELETE /api/v1/certificates/[id]', () => {
it('deletes a certificate', async () => {
mockDelete.mockResolvedValue(undefined as any);
const response = await DELETE(createMockRequest({ method: 'DELETE' }), { params: Promise.resolve({ id: '1' }) });
const data = await response.json();
expect(response.status).toBe(200);
expect(data).toEqual({ ok: true });
expect(mockDelete).toHaveBeenCalledWith(1, 1);
});
it('returns 500 when certificate not found', async () => {
mockDelete.mockRejectedValue(new Error('not found'));
const response = await DELETE(createMockRequest({ method: 'DELETE' }), { params: Promise.resolve({ id: '999' }) });
const data = await response.json();
expect(response.status).toBe(500);
expect(data.error).toBe('not found');
});
});
describe('POST /api/v1/certificates - input variations', () => {
it('creates managed certificate with provider_options', async () => {
const managedCert = {
name: 'Wildcard',
type: 'managed',
domain_names: ['*.example.com'],
auto_renew: true,
provider_options: { api_token: 'cloudflare-token' },
};
mockCreate.mockResolvedValue({
id: 10,
...managedCert,
certificate_pem: null,
private_key_pem: null,
created_at: '2026-01-01T00:00:00Z',
updated_at: '2026-01-01T00:00:00Z',
} as any);
const response = await POST(createMockRequest({ method: 'POST', body: managedCert }));
const data = await response.json();
expect(response.status).toBe(201);
expect(data.id).toBe(10);
expect(data.type).toBe('managed');
expect(data.provider_options).toEqual({ api_token: 'cloudflare-token' });
expect(data.certificate_pem).toBeNull();
expect(data.private_key_pem).toBeNull();
expect(mockCreate).toHaveBeenCalledWith(managedCert, 1);
});
it('creates imported certificate with PEM', async () => {
const importedCert = {
name: 'Custom Cert',
type: 'imported',
domain_names: ['custom.example.com'],
auto_renew: false,
certificate_pem: '-----BEGIN CERTIFICATE-----\nMIIB...\n-----END CERTIFICATE-----',
private_key_pem: '-----BEGIN PRIVATE KEY-----\nMIIE...\n-----END PRIVATE KEY-----',
};
mockCreate.mockResolvedValue({
id: 11,
...importedCert,
created_at: '2026-01-01T00:00:00Z',
updated_at: '2026-01-01T00:00:00Z',
} as any);
const response = await POST(createMockRequest({ method: 'POST', body: importedCert }));
const data = await response.json();
expect(response.status).toBe(201);
expect(data.id).toBe(11);
expect(data.type).toBe('imported');
expect(data.certificate_pem).toContain('BEGIN CERTIFICATE');
expect(data.private_key_pem).toContain('BEGIN PRIVATE KEY');
expect(mockCreate).toHaveBeenCalledWith(importedCert, 1);
});
});
describe('GET /api/v1/certificates/[id] - full fields', () => {
it('returns certificate with all fields', async () => {
const fullCert = {
id: 1,
name: 'Full Cert',
type: 'imported',
domains: ['secure.example.com'],
domain_names: ['secure.example.com'],
status: 'active',
auto_renew: false,
provider_options: null,
certificate_pem: '-----BEGIN CERTIFICATE-----\nMIIB...\n-----END CERTIFICATE-----',
private_key_pem: '-----BEGIN PRIVATE KEY-----\nMIIE...\n-----END PRIVATE KEY-----',
expires_at: '2027-01-01',
created_at: '2026-01-01',
updated_at: '2026-01-01',
};
mockGet.mockResolvedValue(fullCert as any);
const response = await getGET(createMockRequest(), { params: Promise.resolve({ id: '1' }) });
const data = await response.json();
expect(response.status).toBe(200);
expect(data.id).toBe(1);
expect(data.name).toBe('Full Cert');
expect(data.type).toBe('imported');
expect(data.certificate_pem).toContain('BEGIN CERTIFICATE');
expect(data.private_key_pem).toContain('BEGIN PRIVATE KEY');
expect(data.auto_renew).toBe(false);
expect(data.created_at).toBe('2026-01-01');
expect(data.updated_at).toBe('2026-01-01');
});
});