Complete lint remediation addressing errcheck, gosec, and staticcheck violations across backend test files. Tighten pre-commit configuration to prevent future blind spots. Key Changes: - Fix 61 Go linting issues (errcheck, gosec G115/G301/G304/G306, bodyclose) - Add proper error handling for json.Unmarshal, os.Setenv, db.Close(), w.Write() - Fix gosec G115 integer overflow with strconv.FormatUint - Add #nosec annotations with justifications for test fixtures - Fix SecurityService goroutine leaks (add Close() calls) - Fix CrowdSec tar.gz non-deterministic ordering with sorted keys Pre-commit Hardening: - Remove test file exclusion from golangci-lint hook - Add gosec to .golangci-fast.yml with critical checks (G101, G110, G305) - Replace broad .golangci.yml exclusions with targeted path-specific rules - Test files now linted on every commit Test Fixes: - Fix emergency route count assertions (1→2 for dual-port setup) - Fix DNS provider service tests with proper mock setup - Fix certificate service tests with deterministic behavior Backend: 27 packages pass, 83.5% coverage Frontend: 0 lint warnings, 0 TypeScript errors Pre-commit: All 14 hooks pass (~37s)
125 lines
3.2 KiB
Go
125 lines
3.2 KiB
Go
package handlers
|
|
|
|
import (
|
|
"io"
|
|
"net/http"
|
|
"os"
|
|
"strconv"
|
|
"strings"
|
|
|
|
"github.com/Wikid82/charon/backend/internal/logger"
|
|
"github.com/Wikid82/charon/backend/internal/models"
|
|
"github.com/Wikid82/charon/backend/internal/services"
|
|
"github.com/gin-gonic/gin"
|
|
)
|
|
|
|
type LogsHandler struct {
|
|
service *services.LogService
|
|
}
|
|
|
|
var createTempFile = os.CreateTemp
|
|
|
|
func NewLogsHandler(service *services.LogService) *LogsHandler {
|
|
return &LogsHandler{service: service}
|
|
}
|
|
|
|
func (h *LogsHandler) List(c *gin.Context) {
|
|
logs, err := h.service.ListLogs()
|
|
if err != nil {
|
|
c.JSON(http.StatusInternalServerError, gin.H{"error": "Failed to list logs"})
|
|
return
|
|
}
|
|
c.JSON(http.StatusOK, logs)
|
|
}
|
|
|
|
func (h *LogsHandler) Read(c *gin.Context) {
|
|
filename := c.Param("filename")
|
|
|
|
// Parse query parameters
|
|
limit, _ := strconv.Atoi(c.DefaultQuery("limit", "50"))
|
|
offset, _ := strconv.Atoi(c.DefaultQuery("offset", "0"))
|
|
|
|
filter := models.LogFilter{
|
|
Search: c.Query("search"),
|
|
Host: c.Query("host"),
|
|
Status: c.Query("status"),
|
|
Level: c.Query("level"),
|
|
Limit: limit,
|
|
Offset: offset,
|
|
Sort: c.DefaultQuery("sort", "desc"),
|
|
}
|
|
|
|
logs, total, err := h.service.QueryLogs(filename, filter)
|
|
if err != nil {
|
|
if os.IsNotExist(err) {
|
|
c.JSON(http.StatusNotFound, gin.H{"error": "Log file not found"})
|
|
return
|
|
}
|
|
c.JSON(http.StatusInternalServerError, gin.H{"error": "Failed to read log"})
|
|
return
|
|
}
|
|
|
|
c.JSON(http.StatusOK, gin.H{
|
|
"filename": filename,
|
|
"logs": logs,
|
|
"total": total,
|
|
"limit": limit,
|
|
"offset": offset,
|
|
})
|
|
}
|
|
|
|
func (h *LogsHandler) Download(c *gin.Context) {
|
|
filename := c.Param("filename")
|
|
path, err := h.service.GetLogPath(filename)
|
|
if err != nil {
|
|
if strings.Contains(err.Error(), "invalid filename") {
|
|
c.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
|
|
return
|
|
}
|
|
c.JSON(http.StatusNotFound, gin.H{"error": "Log file not found"})
|
|
return
|
|
}
|
|
|
|
// Create a temporary file to serve a consistent snapshot
|
|
// This prevents Content-Length mismatches if the live log file grows during download
|
|
tmpFile, err := createTempFile("", "charon-log-*.log")
|
|
if err != nil {
|
|
c.JSON(http.StatusInternalServerError, gin.H{"error": "Failed to create temp file"})
|
|
return
|
|
}
|
|
defer func() {
|
|
if err := os.Remove(tmpFile.Name()); err != nil {
|
|
logger.Log().WithError(err).Warn("failed to remove temp file")
|
|
}
|
|
}()
|
|
|
|
// #nosec G304 -- path is validated via LogService.GetLogPath
|
|
srcFile, err := os.Open(path)
|
|
if err != nil {
|
|
if err := tmpFile.Close(); err != nil {
|
|
logger.Log().WithError(err).Warn("failed to close temp file")
|
|
}
|
|
c.JSON(http.StatusInternalServerError, gin.H{"error": "Failed to open log file"})
|
|
return
|
|
}
|
|
defer func() {
|
|
if err := srcFile.Close(); err != nil {
|
|
logger.Log().WithError(err).Warn("failed to close source log file")
|
|
}
|
|
}()
|
|
|
|
if _, err := io.Copy(tmpFile, srcFile); err != nil {
|
|
if err := tmpFile.Close(); err != nil {
|
|
logger.Log().WithError(err).Warn("failed to close temp file after copy error")
|
|
}
|
|
c.JSON(http.StatusInternalServerError, gin.H{"error": "Failed to copy log file"})
|
|
return
|
|
}
|
|
if err := tmpFile.Close(); err != nil {
|
|
logger.Log().WithError(err).Warn("failed to close temp file after copy")
|
|
}
|
|
|
|
c.Header("Content-Disposition", "attachment; filename="+filename)
|
|
c.File(tmpFile.Name())
|
|
}
|