032d475fba
Complete lint remediation addressing errcheck, gosec, and staticcheck violations across backend test files. Tighten pre-commit configuration to prevent future blind spots. Key Changes: - Fix 61 Go linting issues (errcheck, gosec G115/G301/G304/G306, bodyclose) - Add proper error handling for json.Unmarshal, os.Setenv, db.Close(), w.Write() - Fix gosec G115 integer overflow with strconv.FormatUint - Add #nosec annotations with justifications for test fixtures - Fix SecurityService goroutine leaks (add Close() calls) - Fix CrowdSec tar.gz non-deterministic ordering with sorted keys Pre-commit Hardening: - Remove test file exclusion from golangci-lint hook - Add gosec to .golangci-fast.yml with critical checks (G101, G110, G305) - Replace broad .golangci.yml exclusions with targeted path-specific rules - Test files now linted on every commit Test Fixes: - Fix emergency route count assertions (1→2 for dual-port setup) - Fix DNS provider service tests with proper mock setup - Fix certificate service tests with deterministic behavior Backend: 27 packages pass, 83.5% coverage Frontend: 0 lint warnings, 0 TypeScript errors Pre-commit: All 14 hooks pass (~37s)
100 lines
2.8 KiB
Go
100 lines
2.8 KiB
Go
package handlers
|
|
|
|
import (
|
|
"encoding/json"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/Wikid82/charon/backend/internal/services"
|
|
"github.com/gin-gonic/gin"
|
|
)
|
|
|
|
// Use a real BackupService, but point it at tmpDir for isolation
|
|
|
|
func TestBackupHandlerQuick(t *testing.T) {
|
|
gin.SetMode(gin.TestMode)
|
|
tmpDir := t.TempDir()
|
|
// prepare a fake "database" so CreateBackup can find it
|
|
dbPath := filepath.Join(tmpDir, "db.sqlite")
|
|
if err := os.WriteFile(dbPath, []byte("db"), 0o600); err != nil {
|
|
t.Fatalf("failed to create tmp db: %v", err)
|
|
}
|
|
|
|
svc := &services.BackupService{DataDir: tmpDir, BackupDir: tmpDir, DatabaseName: "db.sqlite", Cron: nil}
|
|
h := NewBackupHandler(svc)
|
|
|
|
r := gin.New()
|
|
// register routes used
|
|
r.GET("/backups", h.List)
|
|
r.POST("/backups", h.Create)
|
|
r.DELETE("/backups/:filename", h.Delete)
|
|
r.GET("/backups/:filename", h.Download)
|
|
r.POST("/backups/:filename/restore", h.Restore)
|
|
|
|
// List
|
|
w := httptest.NewRecorder()
|
|
req := httptest.NewRequest(http.MethodGet, "/backups", http.NoBody)
|
|
r.ServeHTTP(w, req)
|
|
if w.Code != http.StatusOK {
|
|
t.Fatalf("expected 200, got %d", w.Code)
|
|
}
|
|
|
|
// Create (backup)
|
|
w2 := httptest.NewRecorder()
|
|
req2 := httptest.NewRequest(http.MethodPost, "/backups", http.NoBody)
|
|
r.ServeHTTP(w2, req2)
|
|
if w2.Code != http.StatusCreated {
|
|
t.Fatalf("create expected 201 got %d", w2.Code)
|
|
}
|
|
|
|
var createResp struct {
|
|
Filename string `json:"filename"`
|
|
}
|
|
if err := json.Unmarshal(w2.Body.Bytes(), &createResp); err != nil {
|
|
t.Fatalf("invalid create json: %v", err)
|
|
}
|
|
|
|
// Delete missing
|
|
w3 := httptest.NewRecorder()
|
|
req3 := httptest.NewRequest(http.MethodDelete, "/backups/missing", http.NoBody)
|
|
r.ServeHTTP(w3, req3)
|
|
if w3.Code != http.StatusNotFound {
|
|
t.Fatalf("delete missing expected 404 got %d", w3.Code)
|
|
}
|
|
|
|
// Download missing
|
|
w4 := httptest.NewRecorder()
|
|
req4 := httptest.NewRequest(http.MethodGet, "/backups/missing", http.NoBody)
|
|
r.ServeHTTP(w4, req4)
|
|
if w4.Code != http.StatusNotFound {
|
|
t.Fatalf("download missing expected 404 got %d", w4.Code)
|
|
}
|
|
|
|
// Download present (use filename returned from create)
|
|
w5 := httptest.NewRecorder()
|
|
req5 := httptest.NewRequest(http.MethodGet, "/backups/"+createResp.Filename, http.NoBody)
|
|
r.ServeHTTP(w5, req5)
|
|
if w5.Code != http.StatusOK {
|
|
t.Fatalf("download expected 200 got %d", w5.Code)
|
|
}
|
|
|
|
// Restore missing
|
|
w6 := httptest.NewRecorder()
|
|
req6 := httptest.NewRequest(http.MethodPost, "/backups/missing/restore", http.NoBody)
|
|
r.ServeHTTP(w6, req6)
|
|
if w6.Code != http.StatusNotFound {
|
|
t.Fatalf("restore missing expected 404 got %d", w6.Code)
|
|
}
|
|
|
|
// Restore ok
|
|
w7 := httptest.NewRecorder()
|
|
req7 := httptest.NewRequest(http.MethodPost, "/backups/"+createResp.Filename+"/restore", http.NoBody)
|
|
r.ServeHTTP(w7, req7)
|
|
if w7.Code != http.StatusOK {
|
|
t.Fatalf("restore expected 200 got %d", w7.Code)
|
|
}
|
|
}
|