Compare commits

...

3 Commits

9 changed files with 1434 additions and 712 deletions

View File

@@ -7,6 +7,7 @@ sensitive_paths:
- scripts/history-rewrite/
- data/backups
- docs/plans/history_rewrite.md
- .github/workflows/
- .github/agents/
- .vscode/
- scripts/history-rewrite/preview_removals.sh
- scripts/history-rewrite/clean_history.sh

20
.github/renovate.json vendored
View File

@@ -7,7 +7,8 @@
"helpers:pinGitHubActionDigests"
],
"baseBranches": [
"development"
"development",
"feature/*"
],
"timezone": "America/New_York",
"dependencyDashboard": true,
@@ -28,7 +29,7 @@
],
"rangeStrategy": "bump",
"automerge": true,
"automerge": false,
"automergeType": "pr",
"platformAutomerge": true,
@@ -123,8 +124,19 @@
"pin",
"digest"
],
"groupName": "weekly-non-major-updates",
"automerge": true
"groupName": "weekly-non-major-updates"
},
{
"description": "Feature branches: Always require manual approval",
"matchBaseBranches": ["feature/*"],
"automerge": false
},
{
"description": "Development branch: Auto-merge non-major updates after proven stable",
"matchBaseBranches": ["development"],
"matchUpdateTypes": ["minor", "patch", "pin", "digest"],
"automerge": true,
"minimumReleaseAge": "3 days"
},
{
"description": "Preserve your custom Caddy patch labels but allow them to group into the weekly PR",

View File

@@ -232,50 +232,13 @@ jobs:
docker stop charon-nightly
docker rm charon-nightly
build-nightly-release:
needs: test-nightly-image
runs-on: ubuntu-latest
permissions:
contents: read
steps:
- name: Checkout nightly branch
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
ref: nightly
fetch-depth: 0
- name: Set up Go
uses: actions/setup-go@7a3fe6cf4cb3a834922a1244abfce67bcef6a0c5 # v6.2.0
with:
go-version: '1.25.6'
- name: Set up Node.js
uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
with:
node-version: '24.13.0'
- name: Build frontend
working-directory: ./frontend
run: |
npm ci
npm run build
- name: Run GoReleaser (snapshot mode)
uses: goreleaser/goreleaser-action@e435ccd777264be153ace6237001ef4d979d3a7a # v6.4.0
with:
distribution: goreleaser
version: '~> v2'
args: release --snapshot --skip=publish --clean
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Upload nightly binaries
uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0
with:
name: nightly-binaries
path: dist/*
retention-days: 30
# NOTE: Standalone binary builds removed - Charon uses Docker-only deployment
# The build-nightly-release job that ran GoReleaser for Windows/macOS/Linux binaries
# was removed because:
# 1. Charon is distributed exclusively via Docker images
# 2. Cross-compilation was failing due to Unix-specific syscalls
# 3. No users download standalone binaries (all use Docker)
# If standalone binaries are needed in the future, re-add the job with Linux-only targets
verify-nightly-supply-chain:
needs: build-and-push-nightly

View File

@@ -3,6 +3,24 @@
name: Playwright E2E Tests
on:
push:
branches:
- main
- development
- 'feature/**'
paths:
- 'frontend/**'
- 'backend/**'
- 'tests/**'
- 'playwright.config.js'
- '.github/workflows/playwright.yml'
pull_request:
branches:
- main
- development
- 'feature/**'
workflow_run:
workflows: ["Docker Build, Publish & Test"]
types:

View File

@@ -86,7 +86,9 @@ jobs:
}
// Load propagation config (list of sensitive paths) from .github/propagate-config.yml when available
let configPaths = ['scripts/history-rewrite/', 'data/backups', 'docs/plans/history_rewrite.md', '.github/workflows/'];
// NOTE: .github/workflows/ was removed from defaults - workflow updates SHOULD propagate
// to ensure downstream branches have correct CI/CD configurations
let configPaths = ['scripts/history-rewrite/', 'data/backups', 'docs/plans/history_rewrite.md'];
try {
const configResp = await github.rest.repos.getContent({ owner: context.repo.owner, repo: context.repo.repo, path: '.github/propagate-config.yml', ref: src });
const contentStr = Buffer.from(configResp.data.content, 'base64').toString('utf8');

5
.gitignore vendored
View File

@@ -9,11 +9,6 @@
docs/reports/performance_diagnostics.md
docs/plans/chores.md
# -----------------------------------------------------------------------------
# VS Code
# -----------------------------------------------------------------------------
.vscode/**
# -----------------------------------------------------------------------------
# Python (pre-commit, tooling)
# -----------------------------------------------------------------------------

14
.vscode/mcp.json vendored Normal file
View File

@@ -0,0 +1,14 @@
{
"servers": {
"microsoft/playwright-mcp": {
"type": "stdio",
"command": "npx",
"args": [
"@playwright/mcp@latest"
],
"gallery": "https://api.mcp.github.com",
"version": "0.0.1-seed"
}
},
"inputs": []
}

View File

@@ -1,53 +1,574 @@
# Architecture Analysis: Docker-Only vs Cross-Platform Binaries
# Propagate-Changes Workflow Failure - Investigation Report
**Date:** 2026-01-30
**Status:** Analysis Complete - Recommendation Ready
**Decision Type:** Critical Path Simplification
**Priority:** High (Blocks unnecessary complexity)
**Date:** January 30, 2026
**Investigator:** Planning Agent
**Status:** 🔴 ROOT CAUSE IDENTIFIED - Configuration file blocking workflow changes
---
## Executive Summary
**RECOMMENDATION: Remove Windows/macOS build targets from GoReleaser and simplify to Docker-only distribution.**
Investigation of workflow run [#21532969700](https://github.com/Wikid82/Charon/actions/runs/21532969700/job/62053071596) reveals that the **propagate-changes workflow completed successfully but did NOT create a PR** because `.github/workflows/` is still listed in the `sensitive_paths` configuration file, causing all workflow file changes to be blocked from propagation.
Charon is documented, architected, and distributed **exclusively as a Docker container**. The cross-platform binary builds in `.goreleaser.yaml` are **artifacts from template boilerplate** that serve no practical purpose and waste CI resources.
**Root Cause:** Mismatch between workflow code comment (claiming `.github/workflows/` was removed from sensitive paths) and the actual configuration file (`.github/propagate-config.yml`) which still blocks workflow paths.
---
## Evidence Gathered
## 1. Root Cause Analysis
### 1. Architecture Verification ✅
### 🔴 CRITICAL: Configuration File Still Blocks Workflow Changes
**Source:** `ARCHITECTURE.md` (Lines 1-1300)
```markdown
## System Architecture
Charon follows a **monolithic architecture** with an embedded reverse proxy,
packaged as a single Docker container.
### Single Container Architecture
**Rationale:** Simplicity over scalability - target audience is home users and small teams
**Container Contents:**
- Frontend static files (Vite build output)
- Go backend binary
- Embedded Caddy server
- SQLite database file
- Caddy certificates
- CrowdSec local database
**Evidence from `.github/propagate-config.yml`:**
```yaml
sensitive_paths:
- scripts/history-rewrite/
- data/backups
- docs/plans/history_rewrite.md
- .github/workflows/ # <-- THIS BLOCKS ALL WORKFLOW CHANGES
- scripts/history-rewrite/preview_removals.sh
- scripts/history-rewrite/clean_history.sh
```
**Verdict:** Documented as Docker-only, single-container architecture.
**Contradicting Comment in Workflow (line 84-85):**
```javascript
// NOTE: .github/workflows/ was removed from defaults - workflow updates SHOULD propagate
// to ensure downstream branches have correct CI/CD configurations
```
### Logic Flow That Caused the Skip
1. Push made to `main` branch (triggering workflow)
2. Workflow compared `main` to `development`
3. Found files changed included `.github/workflows/*` paths
4. Loaded `.github/propagate-config.yml` which contains `.github/workflows/`
5. **Matched sensitive path**`core.info()` logged skip message
6. PR creation skipped, workflow exits with green status ✅
---
### 2. User Documentation ✅
## 2. Other Potential Causes Eliminated
**Source:** `README.md` (Lines 1-150)
| Potential Cause | Verdict | Evidence |
|----------------|---------|----------|
| Push by github-actions[bot] | ❌ Unlikely | User-triggered push would have different actor |
| `github.event.pusher == null` | ❌ Unlikely | Push events always have pusher context |
| Main already synced with dev | ❌ No | Workflow CI changes would create diff |
| Existing open PR | ❌ Unknown | Would need `gh pr list` to verify |
| **Sensitive path blocking** | ✅ **ROOT CAUSE** | `.github/workflows/` in config file |
**Installation Methods Documented:**
1. Docker Compose (Recommended)
---
## 3. Recommended Fix
### Option A: Remove `.github/workflows/` from Sensitive Paths (Recommended)
Edit `.github/propagate-config.yml`:
```yaml
sensitive_paths:
- scripts/history-rewrite/
- data/backups
- docs/plans/history_rewrite.md
# REMOVED: .github/workflows/ - workflow updates should propagate
- scripts/history-rewrite/preview_removals.sh
- scripts/history-rewrite/clean_history.sh
```
**Rationale:**
- CI/CD changes SHOULD propagate to keep all branches in sync
- The original intent (documented in workflow comment) was to allow this
- Downstream branches with outdated workflows cause CI failures
### Option B: Add Specific Exclusions Instead
If certain workflows should NOT propagate, use specific paths:
```yaml
sensitive_paths:
- scripts/history-rewrite/
- data/backups
- docs/plans/history_rewrite.md
- .github/workflows/propagate-changes.yml # Only block self-propagation
- scripts/history-rewrite/preview_removals.sh
- scripts/history-rewrite/clean_history.sh
```
---
## 4. Additional Findings
### Workflow Logic Analysis
The workflow has robust logic for:
- ✅ Checking existing PRs before creating duplicates
- ✅ Comparing commits (ahead_by check)
- ✅ Loading external config file for sensitive paths
- ✅ Proper error handling with `core.warning()`
### Potential Edge Case: Skip Condition
```yaml
if: github.actor != 'github-actions[bot]' && github.event.pusher != null
```
This condition is **generally safe**, but:
- If a merge is performed by GitHub's merge queue or rebase, `pusher` context may vary
- Consider adding logging to track when this condition fails
---
## 5. Verification Steps After Fix
1. **Apply fix** to `.github/propagate-config.yml`
2. **Push a test change** to `main` that includes workflow modifications
3. **Verify PR creation** in GitHub Actions logs
4. **Check `core.info()` messages** for:
- `"Checking propagation from main to development..."`
- `"Created PR #XXX to merge main into development"`
---
## 6. Previous Investigation (Archived)
The following sections document a previous investigation into Renovate and Playwright configuration issues.
---
# Renovate and Playwright Configuration Issues - Investigation Report (Archived)
**Date:** January 30, 2026
**Investigator:** Planning Agent
**Status:** ⚠️ CRITICAL - Multiple configuration issues found
---
## Executive Summary (Archived)
Investigation reveals that **both Renovate and Playwright workflows have incorrect configurations** that deviate from the user's required behavior. The Renovate configuration is missing feature branch support and has incorrect automerge settings. The Playwright workflow is missing push event triggers.
---
## 1. Renovate Configuration Issues
### File Locations
- **Primary Config:** `.github/renovate.json` (154 lines)
- **Workflow:** `.github/workflows/renovate.yml` (31 lines)
### 🔴 CRITICAL ISSUE #1: Missing Feature Branch Support
**Current State (BROKEN):**
```json
"baseBranches": [
"development"
]
```
- **Line:** `.github/renovate.json:9`
- **Problem:** Only targets `development` branch
- **Impact:** Feature branches (`feature/*`) receive NO Renovate updates
**Required State:**
```json
"baseBranches": [
"development",
"feature/*"
]
```
---
### 🔴 CRITICAL ISSUE #2: Automerge Enabled Globally
**Current State (BROKEN):**
```json
"automerge": true,
"automergeType": "pr",
"platformAutomerge": true,
```
- **Lines:** `.github/renovate.json:28-30`
- **Problem:** All non-major updates auto-merge immediately
- **Impact:** Updates merge before compatibility is proven
**Required State:**
- **Feature Branches:** Manual approval required (automerge: false)
- **Development Branch:** Let PRs sit until proven compatible
- **Major Updates:** Already correctly set to manual review (line 148)
---
### 🟡 ISSUE #3: Grouped Updates Configuration
**Current State (PARTIALLY CORRECT):**
```json
{
"description": "THE MEGAZORD: Group ALL non-major updates (NPM, Docker, Go, Actions) into one weekly PR",
"matchPackagePatterns": ["*"],
"matchUpdateTypes": [
"minor",
"patch",
"pin",
"digest"
],
"groupName": "weekly-non-major-updates",
"automerge": true
}
```
- **Lines:** `.github/renovate.json:116-127`
- **Status:** ✅ Grouping behavior is CORRECT
- **Problem:** ❌ Automerge should be conditional on branch
---
### 🟢 CORRECT Configuration
**These are working as intended:**
- ✅ Major updates are separate and require manual review (line 145-148)
- ✅ Weekly schedule (Monday 8am, line 23-25)
- ✅ Grouped minor/patch updates (line 116-127)
- ✅ Custom managers for Dockerfile, scripts (lines 32-113)
---
## 2. Playwright Workflow Issues
### File Locations
- **Primary Workflow:** `.github/workflows/playwright.yml` (319 lines)
- **Alternative E2E:** `.github/workflows/e2e-tests.yml` (533 lines)
### 🔴 CRITICAL ISSUE #4: Missing Push Event Triggers
**Current State (BROKEN):**
```yaml
on:
workflow_run:
workflows: ["Docker Build, Publish & Test"]
types:
- completed
workflow_dispatch:
inputs:
pr_number:
description: 'PR number to test (optional)'
required: false
type: string
```
- **Lines:** `.github/workflows/playwright.yml:4-15`
- **Problem:** Only runs after `docker-build.yml` completes, NOT on direct pushes
- **Impact:** User pushed code and Playwright tests did NOT run
**Root Cause Analysis:**
The workflow uses `workflow_run` trigger which:
1. Waits for "Docker Build, Publish & Test" to finish
2. Only triggers if that workflow was triggered by `pull_request` or `push`
3. BUT the condition on line 28-30 filters execution:
```yaml
if: >-
github.event_name == 'workflow_dispatch' ||
((github.event.workflow_run.event == 'pull_request' || github.event.workflow_run.event == 'push') &&
github.event.workflow_run.conclusion == 'success')
```
**Required State:**
```yaml
on:
push:
branches:
- main
- development
- 'feature/**'
paths:
- 'frontend/**'
- 'backend/**'
- 'tests/**'
- 'playwright.config.js'
- '.github/workflows/playwright.yml'
pull_request:
branches:
- main
- development
- 'feature/**'
workflow_run:
workflows: ["Docker Build, Publish & Test"]
types:
- completed
workflow_dispatch:
inputs:
pr_number:
description: 'PR number to test (optional)'
required: false
type: string
```
---
### 🟡 ISSUE #5: Alternative E2E Workflow Exists
**Discovery:**
- File: `.github/workflows/e2e-tests.yml`
- **Lines 31-50:** Has CORRECT push/PR triggers:
```yaml
on:
pull_request:
branches:
- main
- development
- 'feature/**'
paths:
- 'frontend/**'
- 'backend/**'
- 'tests/**'
- 'playwright.config.js'
- '.github/workflows/e2e-tests.yml'
push:
branches:
- main
- development
- 'feature/**'
```
**Question:** Are there TWO Playwright workflows?
- `playwright.yml` - Runs after Docker build (BROKEN triggers)
- `e2e-tests.yml` - Runs on push/PR (CORRECT triggers)
**Impact:** Confusion about which workflow should be the primary E2E test runner
---
## 3. Required Changes Summary
### Renovate Configuration Changes
**File:** `.github/renovate.json`
#### Change #1: Add Feature Branch Support
```diff
"baseBranches": [
- "development"
+ "development",
+ "feature/*"
],
```
- **Line:** 9
- **Priority:** 🔴 CRITICAL
#### Change #2: Conditional Automerge by Branch
```diff
- "automerge": true,
- "automergeType": "pr",
- "platformAutomerge": true,
```
Replace with:
```json
"packageRules": [
{
"description": "Feature branches: Require manual approval",
"matchBaseBranches": ["feature/*"],
"automerge": false
},
{
"description": "Development branch: Automerge after compatibility proven",
"matchBaseBranches": ["development"],
"automerge": true,
"automergeType": "pr",
"platformAutomerge": true,
"minimumReleaseAge": "3 days"
}
]
```
- **Lines:** 28-30 (delete) + add to packageRules section
- **Priority:** 🔴 CRITICAL
#### Change #3: Update Grouped Updates Rule
```diff
{
"description": "THE MEGAZORD: Group ALL non-major updates (NPM, Docker, Go, Actions) into one weekly PR",
"matchPackagePatterns": ["*"],
"matchUpdateTypes": [
"minor",
"patch",
"pin",
"digest"
],
"groupName": "weekly-non-major-updates",
- "automerge": true
}
```
- **Lines:** 116-127
- **Priority:** 🟡 HIGH (automerge now controlled by branch-specific rules)
---
### Playwright Workflow Changes
**File:** `.github/workflows/playwright.yml`
#### Option A: Add Direct Push Triggers (Recommended)
```diff
on:
+ push:
+ branches:
+ - main
+ - development
+ - 'feature/**'
+ paths:
+ - 'frontend/**'
+ - 'backend/**'
+ - 'tests/**'
+ - 'playwright.config.js'
+ - '.github/workflows/playwright.yml'
+
+ pull_request:
+ branches:
+ - main
+ - development
+ - 'feature/**'
+
workflow_run:
workflows: ["Docker Build, Publish & Test"]
types:
- completed
```
- **Lines:** 4 (insert after)
- **Priority:** 🔴 CRITICAL
#### Option B: Consolidate Workflows
**Alternative Solution:**
1. Delete `playwright.yml` (post-docker workflow)
2. Keep `e2e-tests.yml` as the primary E2E test runner
3. Update documentation to reference `e2e-tests.yml`
**Pros:**
- `e2e-tests.yml` already has correct triggers
- Includes sharding and coverage collection
- More comprehensive test execution
**Cons:**
- Requires updating CI documentation
- May have different artifact/image handling
---
## 4. Verification Steps
### After Applying Renovate Changes
1. **Create test feature branch:**
```bash
git checkout -b feature/test-renovate-config
```
2. **Manually trigger Renovate:**
```bash
# Via GitHub Actions UI
# Or via API
gh workflow run renovate.yml
```
3. **Verify Renovate creates PRs against feature branch**
4. **Verify automerge behavior:**
- Feature branch: PR should NOT automerge
- Development branch: PR should automerge after 3 days
### After Applying Playwright Changes
1. **Create test commit on feature branch:**
```bash
git checkout -b feature/test-playwright-trigger
# Make trivial change to frontend
git commit -am "test: trigger playwright"
git push origin feature/test-playwright-trigger
```
2. **Verify Playwright workflow runs immediately on push**
3. **Check GitHub Actions UI:**
- Workflow should appear in "Actions" tab
- Status should show "running" or "completed"
- Should NOT wait for docker-build workflow
---
## 5. Root Cause Analysis
### Why These Changes Occurred
**Hypothesis:**
Another AI model likely:
1. **Simplified baseBranches** to reduce complexity
2. **Enabled automerge globally** to reduce manual PR overhead
3. **Removed direct push triggers** to avoid duplicate test runs
**Problems with this approach:**
- Violates user's explicit requirements for manual feature branch approval
- Creates risk by auto-merging untested updates
- Breaks CI/CD by preventing push-triggered tests
---
## 6. Implementation Priority
### Immediate (Block Development)
1. 🔴 **Renovate:** Add feature branch support (`.github/renovate.json:9`)
2. 🔴 **Playwright:** Add push triggers (`.github/workflows/playwright.yml:4`)
### High Priority (Block Production)
3. 🟡 **Renovate:** Fix automerge behavior (branch-specific rules)
### Medium Priority (Technical Debt)
4. 🟢 **Consolidate:** Decide on single E2E workflow (playwright.yml vs e2e-tests.yml)
---
## 7. Configuration Comparison Table
| Setting | Current (Broken) | Required | Priority |
|---------|-----------------|----------|----------|
| **Renovate baseBranches** | `["development"]` | `["development", "feature/*"]` | 🔴 CRITICAL |
| **Renovate automerge** | Global `true` | Conditional by branch | 🔴 CRITICAL |
| **Renovate grouping** | ✅ Weekly grouped | ✅ Weekly grouped | 🟢 OK |
| **Renovate major updates** | ✅ Manual review | ✅ Manual review | 🟢 OK |
| **Playwright triggers** | `workflow_run` only | `push` + `pull_request` + `workflow_run` | 🔴 CRITICAL |
| **E2E workflow count** | 2 workflows | 1 workflow (consolidate) | 🟡 HIGH |
---
## 8. Next Steps
1. **Review this specification** with the user
2. **Apply critical changes** to Renovate and Playwright configs
3. **Test changes** on feature branch before merging
4. **Document decision** on e2e-tests.yml vs playwright.yml consolidation
5. **Update CI/CD documentation** to reflect correct workflow triggers
---
## Appendix: File References
### Renovate Configuration
- **Primary Config:** `.github/renovate.json`
- Line 9: `baseBranches` (NEEDS FIX)
- Lines 28-30: Global `automerge` (NEEDS FIX)
- Lines 116-127: Grouped updates (NEEDS UPDATE)
- Lines 145-148: Major updates (CORRECT)
### Playwright Workflows
- **Primary:** `.github/workflows/playwright.yml`
- Lines 4-15: `on:` triggers (NEEDS FIX)
- Lines 28-30: Execution condition (REVIEW)
- **Alternative:** `.github/workflows/e2e-tests.yml`
- Lines 31-50: `on:` triggers (CORRECT - consider as model)
---
**End of Investigation Report**
2. Docker Run (One Command)
3. Alternative: GitHub Container Registry

File diff suppressed because it is too large Load Diff