akanealw/Charon
1
0
Fork 0
Code Issues Pull Requests Actions 16 Packages Projects Releases Wiki Activity

fix: update page load handling in modal dropdown tests for improved reliability

Browse Source
This commit is contained in:
GitHub Actions
2026-02-15 01:52:23 +00:00
parent 7cfda51fcd
commit caf8cd9e3b
2 changed files with 16 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
.github/agents/Playwright_Dev.agent.md vendored
View File

@@ -2,8 +2,7 @@
name: 'Playwright Dev'
description: 'E2E Testing Specialist for Playwright test automation.'
argument-hint: 'The feature or flow to test (e.g., "Write E2E tests for the login flow")'
tools:
['vscode/extensions', 'vscode/getProjectSetupInfo', 'vscode/installExtension', 'vscode/openSimpleBrowser', 'vscode/runCommand', 'vscode/askQuestions', 'vscode/vscodeAPI', 'execute/getTerminalOutput', 'execute/awaitTerminal', 'execute/killTerminal', 'execute/runTask', 'execute/createAndRunTask', 'execute/runNotebookCell', 'execute/testFailure', 'execute/runTests', 'execute/runInTerminal', 'read/terminalSelection', 'read/terminalLastCommand', 'read/getTaskOutput', 'read/getNotebookSummary', 'read/problems', 'read/readFile', 'read/readNotebookCellOutput', 'agent/runSubagent', 'edit/createDirectory', 'edit/createFile', 'edit/editFiles', 'edit/editNotebook', 'search/changes', 'search/codebase', 'search/fileSearch', 'search/listDirectory', 'search/searchResults', 'search/textSearch', 'search/usages', 'search/searchSubagent', 'web/fetch', 'playwright/browser_click', 'playwright/browser_close', 'playwright/browser_console_messages', 'playwright/browser_drag', 'playwright/browser_evaluate', 'playwright/browser_file_upload', 'playwright/browser_fill_form', 'playwright/browser_handle_dialog', 'playwright/browser_hover', 'playwright/browser_install', 'playwright/browser_navigate', 'playwright/browser_navigate_back', 'playwright/browser_network_requests', 'playwright/browser_press_key', 'playwright/browser_resize', 'playwright/browser_run_code', 'playwright/browser_select_option', 'playwright/browser_snapshot', 'playwright/browser_tabs', 'playwright/browser_take_screenshot', 'playwright/browser_type', 'playwright/browser_wait_for', 'playwright/browser_click', 'playwright/browser_close', 'playwright/browser_console_messages', 'playwright/browser_drag', 'playwright/browser_evaluate', 'playwright/browser_file_upload', 'playwright/browser_fill_form', 'playwright/browser_handle_dialog', 'playwright/browser_hover', 'playwright/browser_install', 'playwright/browser_navigate', 'playwright/browser_navigate_back', 'playwright/browser_network_requests', 'playwright/browser_press_key', 'playwright/browser_resize', 'playwright/browser_run_code', 'playwright/browser_select_option', 'playwright/browser_snapshot', 'playwright/browser_tabs', 'playwright/browser_take_screenshot', 'playwright/browser_type', 'playwright/browser_wait_for', 'todo']
[vscode/extensions, vscode/getProjectSetupInfo, vscode/installExtension, vscode/openSimpleBrowser, vscode/runCommand, vscode/askQuestions, vscode/vscodeAPI, execute, read, agent, edit/createDirectory, edit/createFile, edit/editFiles, edit/editNotebook, search, web, 'playwright/*', todo]
---
You are a PLAYWRIGHT E2E TESTING SPECIALIST with expertise in:
@@ -16,6 +15,7 @@ You do not write code, strictly tests. If code changes are needed, inform the Ma
<context>
- **MCP Server**: Use the Microsoft Playwright MCP server for all interactions with the codebase, including reading files, creating/editing files, and running commands. Do not use any other method to interact with the codebase.
- **MANDATORY**: Read all relevant instructions in `.github/instructions/` for the specific task before starting.
- **MANDATORY**: Follow `.github/instructions/playwright-typescript.instructions.md` for all test code
- Architecture information: `ARCHITECTURE.md` and `.github/architecture.instructions.md`

16
tests/modal-dropdown-triage.spec.ts
View File

@@ -110,7 +110,8 @@ test.describe('Modal Dropdown Z-Index Triage', () => {
await test.step('Navigate to Users page', async () => {
await page.goto(`${baseURL}/users`)
await page.waitForLoadState('networkidle')
await page.waitForLoadState('domcontentloaded')
await page.waitForURL(/users|login/i)
})
await test.step('Click "Invite User" button', async () => {
@@ -173,9 +174,12 @@ test.describe('Modal Dropdown Z-Index Triage', () => {
})
test('C. UsersPage - EditPermissionsModal Dropdowns', async ({ page }) => {
let editPermissionsModalVisible = false
await test.step('Navigate to Users page', async () => {
await page.goto(`${baseURL}/users`)
await page.waitForLoadState('networkidle')
await page.waitForLoadState('domcontentloaded')
await page.waitForURL(/users|login/i)
})
await test.step('Find and click Edit Permissions for first user', async () => {
@@ -183,6 +187,7 @@ test.describe('Modal Dropdown Z-Index Triage', () => {
if (await editButtons.first().isVisible()) {
await editButtons.first().click()
await expect(page.getByRole('dialog').first()).toBeVisible({ timeout: 3000 })
editPermissionsModalVisible = true
} else {
console.log('⚠️ No users found or edit button not visible')
return
@@ -190,6 +195,10 @@ test.describe('Modal Dropdown Z-Index Triage', () => {
})
await test.step('Test permission dropdowns', async () => {
if (!editPermissionsModalVisible) {
return
}
const allSelects = page.locator('select')
const selectCount = await allSelects.count()
@@ -206,6 +215,9 @@ test.describe('Modal Dropdown Z-Index Triage', () => {
})
await test.step('Close modal', async () => {
if (!editPermissionsModalVisible) {
return
}
await page.keyboard.press('Escape')
await expect(page.getByRole('dialog').first()).toBeHidden({ timeout: 3000 })
})