akanealw/Charon
1
0
Fork 0
Code Issues Pull Requests Actions 16 Packages Projects Releases Wiki Activity

Merge pull request #655 from Wikid82/hotfix/ci

Browse Source 
fix(ci): improve Playwright installation steps by removing redundant system dependency installs and enhancing exit code handling
This commit is contained in:
Jeremy
2026-02-04 12:46:15 -05:00
committed by GitHub
parent 985921490f aa74aacf76
commit 835700b91a
1 changed files with 9 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
.github/workflows/e2e-tests-split.yml vendored
View File

@@ -200,18 +200,17 @@ jobs:
- name: Install dependencies
run: npm ci
- name: Install Playwright system dependencies
run: npx playwright install-deps chromium
- name: Install Playwright Chromium
run: |
echo "📦 Installing Chromium..."
npx playwright install --with-deps chromium
echo "✅ Install command completed (exit code: $?)"
EXIT_CODE=$?
echo "✅ Install command completed (exit code: $EXIT_CODE)"
echo "📁 Checking browser cache..."
ls -lR ~/.cache/ms-playwright/ 2>/dev/null || echo "Cache directory not found"
echo "🔍 Searching for chromium executable..."
find ~/.cache/ms-playwright -name "*chromium*" -o -name "*chrome*" 2>/dev/null | head -10 || echo "No chromium files found"
exit $EXIT_CODE
- name: Run Chromium tests (Shard ${{ matrix.shard }}/${{ matrix.total-shards }})
run: |
@@ -366,18 +365,17 @@ jobs:
- name: Install dependencies
run: npm ci
- name: Install Playwright system dependencies
run: npx playwright install-deps firefox
- name: Install Playwright Firefox
run: |
echo "📦 Installing Firefox..."
npx playwright install --with-deps firefox
echo "✅ Install command completed (exit code: $?)"
EXIT_CODE=$?
echo "✅ Install command completed (exit code: $EXIT_CODE)"
echo "📁 Checking browser cache..."
ls -lR ~/.cache/ms-playwright/ 2>/dev/null || echo "Cache directory not found"
echo "🔍 Searching for firefox executable..."
find ~/.cache/ms-playwright -name "*firefox*" 2>/dev/null | head -10 || echo "No firefox files found"
exit $EXIT_CODE
- name: Run Firefox tests (Shard ${{ matrix.shard }}/${{ matrix.total-shards }})
run: |
@@ -532,18 +530,17 @@ jobs:
- name: Install dependencies
run: npm ci
- name: Install Playwright system dependencies
run: npx playwright install-deps webkit
- name: Install Playwright WebKit
run: |
echo "📦 Installing WebKit..."
npx playwright install --with-deps webkit
echo "✅ Install command completed (exit code: $?)"
EXIT_CODE=$?
echo "✅ Install command completed (exit code: $EXIT_CODE)"
echo "📁 Checking browser cache..."
ls -lR ~/.cache/ms-playwright/ 2>/dev/null || echo "Cache directory not found"
echo "🔍 Searching for webkit executable..."
find ~/.cache/ms-playwright -name "*webkit*" -o -name "*MiniBrowser*" 2>/dev/null | head -10 || echo "No webkit files found"
exit $EXIT_CODE
- name: Run WebKit tests (Shard ${{ matrix.shard }}/${{ matrix.total-shards }})
run: |