From 1bd7ad880a0f0bfdabad039825e91d0dd1e89d8c Mon Sep 17 00:00:00 2001
From: Misode <misoloo64@gmail.com>
Date: Sat, 3 Jan 2026 23:11:48 +0100
Subject: [PATCH] Fix #835 handle invalid identifiers in mcdoc renderer

---
 .../components/generator/McdocRenderer.tsx    | 29 ++++++++++++++-----
 1 file changed, 22 insertions(+), 7 deletions(-)

diff --git a/src/app/components/generator/McdocRenderer.tsx b/src/app/components/generator/McdocRenderer.tsx
index a74c40f4..06e9b187 100644
--- a/src/app/components/generator/McdocRenderer.tsx
+++ b/src/app/components/generator/McdocRenderer.tsx
@@ -142,8 +142,6 @@ const SPECIAL_UNSET = '__unset__'
 
 function StringHead({ type, optional, excludeStrings, node, ctx }: Props<StringType>) {
 	const { locale } = useLocale()
-	const { version } = useVersion()
-	const use1204 = !checkVersion(version, '1.20.5')
 
 	const nodeValue = (JsonStringNode.is(node) ? node.value : undefined)?.replaceAll('\n', '\\n')
 	const [value, setValue] = useState(nodeValue)
@@ -207,11 +205,7 @@ function StringHead({ type, optional, excludeStrings, node, ctx }: Props<StringT
 	}, [onChangeValue])
 
 	return <>
-		{((idRegistry === 'item' || idRegistry === 'block') && idTags !== 'implicit' && value && !value.startsWith('#')) && <label>
-			{use1204
-				? <ItemDisplay1204 item={new ItemStack1204(Identifier1204.parse(value), 1)} />
-				: <ItemDisplay item={new ItemStack(Identifier.parse(value), 1)} />}
-		</label>}
+		{((idRegistry === 'item' || idRegistry === 'block') && idTags !== 'implicit' && value && !value.startsWith('#')) && <ItemIdPreview id={value}/>}
 		{isSelect ? <>
 			<select value={value === undefined ? SPECIAL_UNSET : value} onInput={(e) => onChangeValue((e.target as HTMLInputElement).value)}>
 				{(value === undefined || optional) && <option value={SPECIAL_UNSET}>{locale('unset')}</option>}
@@ -234,6 +228,27 @@ function StringHead({ type, optional, excludeStrings, node, ctx }: Props<StringT
 	</>
 }
 
+function ItemIdPreview({ id }: { id: string }) {
+	const { version } = useVersion()
+
+	const stack = useMemo(() => {
+		try {
+			if (!checkVersion(version, '1.20.5')) {
+				return new ItemStack1204(Identifier1204.parse(id), 1)
+			}
+			return new ItemStack(Identifier.parse(id), 1)
+		} catch (e) {
+			return undefined
+		}
+	}, [id, version])
+
+	return <>{stack && <label>
+		{stack instanceof ItemStack1204
+			? <ItemDisplay1204 item={stack} />
+			: <ItemDisplay item={stack} />}
+	</label>}</>
+}
+
 function EnumHead({ type, optional, excludeStrings, node, ctx }: Props<SimplifiedEnum>) {
 	const { locale } = useLocale()