Harden forward auth: store redirect URIs server-side, eliminate client control

Replace client-controlled redirectUri with server-side redirect intents.
The portal server component validates the ?rd= hostname against
isForwardAuthDomain, stores the URI in a new forward_auth_redirect_intents
table, and passes only an opaque rid (128-bit random, SHA-256 hashed) to
the client. Login endpoints consume the intent atomically (one-time use,
10-minute TTL) and retrieve the stored URI — the client never sends the
redirect URL to any API endpoint.

Security properties:
- Redirect URI is never client-controlled in API requests
- rid is 128-bit random, stored as SHA-256 hash (not reversible from DB)
- Atomic one-time consumption prevents replay
- 10-minute TTL limits attack window for OAuth round-trip
- Immediate deletion after consumption
- Expired intents cleaned up opportunistically
- Hostname validated against registered forward-auth domains before storage

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
fuomag9
2026-04-06 18:12:01 +02:00
parent 38d29cb7e0
commit fbf8ca38b0
8 changed files with 157 additions and 53 deletions

View File

@@ -4,13 +4,15 @@ import { config } from "@/src/lib/config";
import {
createForwardAuthSession,
createExchangeCode,
checkHostAccessByDomain
checkHostAccessByDomain,
consumeRedirectIntent
} from "@/src/lib/models/forward-auth";
import { logAuditEvent } from "@/src/lib/audit";
/**
* Forward auth session login — creates a forward auth session from an existing
* NextAuth session (used after OAuth login redirects back to the portal).
* Forward auth session login — uses an existing NextAuth session to create
* a forward auth session. Called automatically when the portal detects the
* user is already logged in (e.g. after OAuth).
*/
export async function POST(request: NextRequest) {
try {
@@ -27,22 +29,19 @@ export async function POST(request: NextRequest) {
}
const body = await request.json();
const redirectUri = typeof body.redirectUri === "string" ? body.redirectUri : "";
const rid = typeof body.rid === "string" ? body.rid : "";
if (!rid) {
return NextResponse.json({ error: "Missing redirect intent" }, { status: 400 });
}
// Consume the redirect intent — returns the server-stored redirect URI
const redirectUri = await consumeRedirectIntent(rid);
if (!redirectUri) {
return NextResponse.json({ error: "Redirect URI is required" }, { status: 400 });
}
let targetUrl: URL;
try {
targetUrl = new URL(redirectUri);
} catch {
return NextResponse.json({ error: "Invalid redirect URI" }, { status: 400 });
}
if (targetUrl.protocol !== "https:" && targetUrl.protocol !== "http:") {
return NextResponse.json({ error: "Invalid redirect URI scheme" }, { status: 400 });
return NextResponse.json({ error: "Invalid or expired redirect intent. Please try again." }, { status: 400 });
}
const targetUrl = new URL(redirectUri);
const userId = Number(session.user.id);
// Check if user has access to the target host