akanealw/caddy-proxy-manager
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Fix L4 port manager failing to recreate caddy after Docker restart

Browse Source 
The sidecar's `docker compose up` command lacked `--pull never`, so
Docker Compose would attempt to pull the caddy image from ghcr.io when
the local image was missing or stale. Since the sidecar has no registry
credentials this failed with 403 Forbidden.

Closes #117

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
fuomag9
2026-04-20 11:35:12 +02:00
parent dbfc340ea4
commit 96bac86934
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
docker/l4-port-manager/entrypoint.sh
View File

@@ -93,7 +93,7 @@ do_apply() {
write_status "applying" "Recreating caddy container with updated ports..." write_status "applying" "Recreating caddy container with updated ports..."
# shellcheck disable=SC2086 # shellcheck disable=SC2086
if docker compose $COMPOSE_ARGS up -d --no-deps --force-recreate caddy 2>&1; then if docker compose $COMPOSE_ARGS up -d --no-deps --pull never --force-recreate caddy 2>&1; then
log "Caddy container recreated successfully." log "Caddy container recreated successfully."
# Wait for caddy healthcheck to pass # Wait for caddy healthcheck to pass

4
tests/unit/l4-port-manager-entrypoint.test.ts
View File

@@ -89,12 +89,12 @@ describe('L4 port manager entrypoint.sh', () => {
expect(script).toContain('"$CURRENT_TRIGGER" = "$LAST_TRIGGER"'); expect(script).toContain('"$CURRENT_TRIGGER" = "$LAST_TRIGGER"');
}); });
it('does not pull images (only recreates)', () => { it('uses --pull never to avoid registry pulls (only recreates)', () => {
const composeUpLines = lines.filter(line => const composeUpLines = lines.filter(line =>
line.includes('docker compose') && line.includes('up') line.includes('docker compose') && line.includes('up')
); );
for (const line of composeUpLines) { for (const line of composeUpLines) {
expect(line).not.toContain('--pull'); expect(line).toContain('--pull never');
expect(line).not.toContain('--build'); expect(line).not.toContain('--build');
} }
}); });