- Updated references from `CPMP_TOKEN` to `CHARON_TOKEN` in beta release draft PR body, beta release PR body, and GitHub setup documentation. - Enhanced clarity in documentation regarding the use of `GITHUB_TOKEN` and fallback options. - Removed outdated sections from the archived plan for the Docs-to-Issues workflow fix, streamlining the document. - Initiated integration of Staticcheck into pre-commit hooks to improve code quality, including updates to Makefile, VS Code tasks, and documentation.
1.8 KiB
1.8 KiB
Beta Release Draft Pull Request
Overview
Draft PR to merge hardened CI/release workflow changes from feature/beta-release into feature/alpha-completion.
Highlights
- Secret token migration: prefer
GITHUB_TOKENwhile maintaining support forCHARON_TOKEN(fallback) where needed. - Release workflow refinements: stable prerelease detection (alpha/beta/rc), artifact matrix intact.
- Prior infra hardening (already partially merged earlier): pinned GitHub Action SHAs/tags, resilient Delve (
dlv) multi-arch build handling. - Extensive incremental documentation trail in
docs/beta_release_draft_pr.mdplus concise snapshot indocs/beta_release_draft_pr_body_snapshot.mdfor reviewers.
Ahead Commits (Representative)
Most recent snapshot commit: 308ae5dd (final body content before PR). Full ordered list in docs/beta_release_draft_pr.md.
Review Checklist
- Secret
GITHUB_TOKEN(orCHARON_TOKENfallback) exists and has required scopes. - No lingering
GITHUB_TOKENorCHARON_TOKENreferences beyond allowed GitHub-provided contexts. - Artifact list (frontend dist, backend binaries, caddy binaries) still correct for release.
Risks & Mitigations
- Secret rename: Mitigate by verifying secret presence before merge.
- Workflow call path validity:
docker-publish.ymlreferenced locally; CI on draft will validate end-to-end.
Deferred Items (Out of Scope Here)
- Frontend test coverage improvements (ProxyHostForm).
- Additional beta observability and import validation tasks.
Actions After Approval
- Confirm CI draft run passes.
- Convert PR from draft to ready-for-review.
- Merge into
feature/alpha-completion.
Request
Please focus review on secret usage, workflow call integrity, and artifact correctness. Comment with any missed token references.
Generated programmatically to aid structured review.