b14f6f040f
- Implement tests for feature flags coverage in `feature_flags_coverage_v2_test.go` to validate behavior with invalid persisted and environment values, as well as default settings. - Create tests in `notification_provider_patch_coverage_test.go` to ensure correct handling of notification provider updates, including blocking type mutations for non-Discord providers. - Add tests in `security_notifications_patch_coverage_test.go` to verify deprecated headers, handle invalid CIDR warnings, and ensure correct severity handling for security events. - Introduce migration error handling tests in `routes_coverage_test.go` to ensure graceful handling of migration errors during registration. - Enhance `cerberus_blockers_test.go` with tests for disabled security event notifications and error handling for dispatch failures. - Update `router_test.go` to validate notify routing based on feature flags. - Refactor `mail_service.go` to normalize base URLs for invites, ensuring proper handling of trailing slashes. - Modify `notification_service_json_test.go` and `notification_service_test.go` to mock Discord validation and improve webhook testing. - Update `proxyhost_service.go` to enhance hostname validation by parsing URLs. - Refine `uptime_service.go` to extract ports correctly from URLs, including handling edge cases. - Enhance frontend tests in `notifications.test.ts` and `Notifications.test.tsx` to ensure correct behavior for Discord notification providers and enforce type constraints.
106 lines
3.1 KiB
Go
106 lines
3.1 KiB
Go
package handlers
|
|
|
|
import (
|
|
"encoding/json"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
|
|
"github.com/Wikid82/charon/backend/internal/models"
|
|
"github.com/gin-gonic/gin"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"gorm.io/driver/sqlite"
|
|
"gorm.io/gorm"
|
|
)
|
|
|
|
// TestResolveRetiredLegacyFallback_InvalidPersistedValue covers lines 139-140
|
|
func TestResolveRetiredLegacyFallback_InvalidPersistedValue(t *testing.T) {
|
|
gin.SetMode(gin.TestMode)
|
|
db, err := gorm.Open(sqlite.Open(":memory:"), &gorm.Config{})
|
|
require.NoError(t, err)
|
|
|
|
require.NoError(t, db.AutoMigrate(&models.Setting{}))
|
|
|
|
// Create setting with invalid value for retired fallback flag
|
|
db.Create(&models.Setting{
|
|
Key: "feature.notifications.legacy.fallback_enabled",
|
|
Value: "invalid_value_not_bool",
|
|
Type: "bool",
|
|
Category: "feature",
|
|
})
|
|
|
|
h := NewFeatureFlagsHandler(db)
|
|
r := gin.New()
|
|
r.GET("/api/v1/feature-flags", h.GetFlags)
|
|
|
|
req := httptest.NewRequest(http.MethodGet, "/api/v1/feature-flags", http.NoBody)
|
|
w := httptest.NewRecorder()
|
|
r.ServeHTTP(w, req)
|
|
|
|
require.Equal(t, http.StatusOK, w.Code)
|
|
|
|
// Should log warning and return false (lines 139-140)
|
|
var flags map[string]bool
|
|
err = json.Unmarshal(w.Body.Bytes(), &flags)
|
|
require.NoError(t, err)
|
|
|
|
assert.False(t, flags["feature.notifications.legacy.fallback_enabled"])
|
|
}
|
|
|
|
// TestResolveRetiredLegacyFallback_InvalidEnvValue covers lines 149-150
|
|
func TestResolveRetiredLegacyFallback_InvalidEnvValue(t *testing.T) {
|
|
gin.SetMode(gin.TestMode)
|
|
db, err := gorm.Open(sqlite.Open(":memory:"), &gorm.Config{})
|
|
require.NoError(t, err)
|
|
|
|
require.NoError(t, db.AutoMigrate(&models.Setting{}))
|
|
|
|
// Set invalid env var for retired fallback flag
|
|
t.Setenv("CHARON_LEGACY_FALLBACK_ENABLED", "not_a_boolean")
|
|
|
|
h := NewFeatureFlagsHandler(db)
|
|
r := gin.New()
|
|
r.GET("/api/v1/feature-flags", h.GetFlags)
|
|
|
|
req := httptest.NewRequest(http.MethodGet, "/api/v1/feature-flags", http.NoBody)
|
|
w := httptest.NewRecorder()
|
|
r.ServeHTTP(w, req)
|
|
|
|
require.Equal(t, http.StatusOK, w.Code)
|
|
|
|
// Should log warning and return false (lines 149-150)
|
|
var flags map[string]bool
|
|
err = json.Unmarshal(w.Body.Bytes(), &flags)
|
|
require.NoError(t, err)
|
|
|
|
assert.False(t, flags["feature.notifications.legacy.fallback_enabled"])
|
|
}
|
|
|
|
// TestResolveRetiredLegacyFallback_DefaultFalse covers lines 157-158
|
|
func TestResolveRetiredLegacyFallback_DefaultFalse(t *testing.T) {
|
|
gin.SetMode(gin.TestMode)
|
|
db, err := gorm.Open(sqlite.Open(":memory:"), &gorm.Config{})
|
|
require.NoError(t, err)
|
|
|
|
require.NoError(t, db.AutoMigrate(&models.Setting{}))
|
|
|
|
// No DB value, no env vars - should default to false
|
|
h := NewFeatureFlagsHandler(db)
|
|
r := gin.New()
|
|
r.GET("/api/v1/feature-flags", h.GetFlags)
|
|
|
|
req := httptest.NewRequest(http.MethodGet, "/api/v1/feature-flags", http.NoBody)
|
|
w := httptest.NewRecorder()
|
|
r.ServeHTTP(w, req)
|
|
|
|
require.Equal(t, http.StatusOK, w.Code)
|
|
|
|
// Should return false (lines 157-158)
|
|
var flags map[string]bool
|
|
err = json.Unmarshal(w.Body.Bytes(), &flags)
|
|
require.NoError(t, err)
|
|
|
|
assert.False(t, flags["feature.notifications.legacy.fallback_enabled"])
|
|
}
|