Files

GitHub Actions 9ad3afbd22 Fix Rate Limiting Issues

- Updated Definition of Done report with detailed checks and results for backend and frontend tests.
- Documented issues related to race conditions and test failures in QA reports.
- Improved security scan notes and code cleanup status in QA reports.
- Added summaries for rate limit integration test fixes, including root causes and resolutions.
- Introduced new debug and integration scripts for rate limit testing.
- Updated security documentation to reflect changes in configuration and troubleshooting steps.
- Enhanced troubleshooting guides for CrowdSec and Go language server (gopls) errors.
- Improved frontend and scripts README files for clarity and usage instructions.

2025-12-12 19:21:44 +00:00

1.5 KiB

Raw Blame History

QA Audit Report: CrowdSec Console Enrollment CAPI Fix

Date: December 11, 2025 Auditor: GitHub Copilot

Summary

A QA audit was performed on the changes to ensure CAPI registration before CrowdSec console enrollment. The changes involved adding a check for online_api_credentials.yaml and running cscli capi register if it's missing.

Scope

backend/internal/crowdsec/console_enroll.go
backend/internal/crowdsec/console_enroll_test.go

Verification Steps

1. Code Review

File: backend/internal/crowdsec/console_enroll.go
- Verified ensureCAPIRegistered method checks for online_api_credentials.yaml.
- Verified ensureCAPIRegistered runs cscli capi register with correct arguments if file is missing.
- Verified Enroll calls ensureCAPIRegistered before enrollment.
File: backend/internal/crowdsec/console_enroll_test.go
- Verified stubEnvExecutor updated to handle multiple calls and return different responses.
- Verified TestConsoleEnrollSuccess asserts capi register is called.
- Verified TestConsoleEnrollIdempotentWhenAlreadyEnrolled asserts correct behavior.
- Verified TestConsoleEnrollFailureRedactsSecret asserts correct behavior with mocked responses.

2. Automated Checks

Tests: Ran go test ./internal/crowdsec/... -v.
- Result: Passed.

Conclusion

The changes have been verified and all tests pass. The implementation correctly ensures CAPI is registered before attempting console enrollment, addressing the reported issue.

1.5 KiB Raw Blame History