Charon/CHANGELOG.md

Changelog

All notable changes to Charon will be documented in this file.

The format is based on Keep a Changelog, and this project adheres to Semantic Versioning.

[Unreleased]

Added

• Test Coverage Improvements: Comprehensive test coverage enhancements across backend and frontend (PR #450)
  • Backend coverage: 86.2% (exceeds 85% threshold)
  • Frontend coverage: 87.27% (exceeds 85% threshold)
  • Added SSRF protection tests for security notification handlers
  • Enhanced integration tests for CrowdSec, WAF, and ACL features
  • Improved IP validation test coverage (IPv4/IPv6 comprehensive)
  • See PR #450 Implementation Summary

Security

• CRITICAL: Complete Server-Side Request Forgery (SSRF) remediation with defense-in-depth architecture (CWE-918, PR #450)
  • CodeQL CWE-918 Fix: Resolved taint tracking issue in url_testing.go:152 by introducing explicit variable to break taint chain
  • Variable requestURL now receives validated output from security.ValidateExternalURL(), eliminating CodeQL false positive
  • Phase 1: Runtime SSRF protection via url_testing.go with connection-time IP validation
    • Implemented custom ssrfSafeDialer() with atomic DNS resolution and IP validation
    • All resolved IPs validated before connection establishment (prevents DNS rebinding/TOCTOU attacks)
    • Validates 13+ CIDR ranges: RFC 1918 private networks, cloud metadata endpoints (169.254.0.0/16), loopback, and link-local addresses
    • HTTP client enforces 5-second timeout and max 2 redirects
  • Phase 2: Handler-level SSRF pre-validation in settings_handler.go TestPublicURL endpoint
    • Pre-connection validation using security.ValidateExternalURL() breaks CodeQL taint chain
    • Rejects embedded credentials (prevents URL parser differential attacks like http://evil.com@127.0.0.1/)
    • Returns HTTP 200 with reachable: false for SSRF blocks (maintains API contract)
    • Admin-only access with comprehensive test coverage (31/31 assertions passing)
  • Defense-in-Depth Architecture: Four-layer protection (format validation → SSRF pre-check → connectivity test → runtime re-validation)
  • Additional Protections:
    • Security notification webhooks validated to prevent SSRF attacks
    • CrowdSec hub URLs validated against allowlist of official domains
    • GitHub update URLs validated before requests
  • Monitoring: All SSRF attempts logged with HIGH severity
  • Validation Strategy: Fail-fast at configuration save + defense-in-depth at request time
  • Pre-remediation CVSS score: 8.6 (HIGH) → Post-remediation: 0.0 (vulnerability eliminated)
  • CodeQL Critical finding resolved - all security tests passing
  • See Complete SSRF Implementation for technical details

Changed

• BREAKING: UpdateService.SetAPIURL() now returns error (internal API only, does not affect users)
• Security notification service now validates webhook URLs before saving and before sending
• CrowdSec hub sync validates hub URLs against allowlist of official domains
• URL connectivity testing endpoint requires admin privileges and applies SSRF protection

Enhanced

• Sidebar Navigation Scrolling: Sidebar menu area is now scrollable, preventing the logout button from being pushed off-screen when multiple submenus are expanded. Includes custom scrollbar styling for better visual consistency.
• Fixed Header Bar: Desktop header bar now remains visible when scrolling the main content area, improving navigation accessibility and user experience.

Changed

• Repository Structure Reorganization: Cleaned up root directory for better navigation
  • Moved docker-compose files to .docker/compose/
  • Moved docker-entrypoint.sh to .docker/
  • Moved 16 implementation docs to docs/implementation/
  • Deleted test artifacts (block_test.txt, caddy_*.json, etc.)
  • Added .github/instructions/structure.instructions.md for ongoing structure enforcement

Added

• Bulk Apply Security Header Profiles: Apply or remove security header profiles from multiple proxy hosts simultaneously via the Bulk Apply modal
• Standard Proxy Headers: Charon now adds X-Real-IP, X-Forwarded-Proto, X-Forwarded-Host, and X-Forwarded-Port headers to all proxy hosts by default. This enables proper client IP detection, HTTPS enforcement, and logging in backend applications.
  • New feature flag: enable_standard_headers (default: true for new hosts, false for existing)
  • UI: Checkbox in proxy host form with info banner explaining backward compatibility
  • Bulk operations: Toggle available in bulk apply modal for enabling/disabling across multiple hosts
  • Migration path: Existing hosts preserve old behavior (headers disabled) for backward compatibility
  • Note: X-Forwarded-For is handled natively by Caddy and not explicitly set by Charon

Changed

• Backend Applications: Applications behind Charon proxies will now receive client IP and protocol information via standard headers when the feature is enabled

Fixed

• Fixed 500 error when saving proxy hosts caused by invalid trusted_proxies structure in Caddy configuration
• Removed redundant handler-level trusted_proxies (server-level configuration already provides global IP spoofing protection)
• Fixed proxy host save failure (500 error) when updating enable_standard_headers, forward_auth_enabled, or waf_disabled fields
• Fixed auth pass-through failure for Seerr/Overseerr caused by missing standard proxy headers

Security

• Trusted Proxies: Caddy configuration now always includes trusted_proxies directive when proxy headers are enabled, preventing IP spoofing attacks by ensuring headers are only trusted from Charon itself

Migration Guide for Existing Users

Existing proxy hosts will have standard headers disabled by default to maintain backward compatibility with applications that may not expect or handle these headers correctly. To enable standard headers on existing hosts:

Option 1: Enable on individual hosts

1. Navigate to Proxy Hosts
2. Click Edit on the desired host
3. Scroll to the Standard Proxy Headers section
4. Check the "Enable Standard Proxy Headers" checkbox
5. Click Save

Option 2: Bulk enable on multiple hosts

1. Navigate to Proxy Hosts
2. Select the checkboxes for hosts you want to update
3. Click the "Bulk Apply" button at the top
4. In the Bulk Apply Settings modal, find "Standard Proxy Headers"
5. Toggle the switch to ON
6. Check the "Apply to selected hosts" checkbox for this setting
7. Click "Apply Changes"

What do these headers do?

• X-Real-IP: Provides the client's actual IP address (bypasses proxy IP)
• X-Forwarded-Proto: Indicates the original protocol (http or https)
• X-Forwarded-Host: Contains the original Host header from the client
• X-Forwarded-Port: Indicates the original port number used by the client
• X-Forwarded-For: Automatically managed by Caddy (shows chain of proxies)

Why the default changed:

Most modern web applications expect these headers for proper logging, security, and functionality. New proxy hosts will have this enabled by default to follow industry best practices.

When to keep headers disabled:

• Legacy applications that don't understand proxy headers
• Applications with custom IP detection logic that might conflict
• Security-sensitive applications where you want to control header injection manually