Files

GitHub Actions e41c4a12da fix: resolve CrowdSec 500 error and state mismatch after container restart

- Make Stop() idempotent: return nil instead of error when PID file missing
- Add startup reconciliation: auto-start CrowdSec if DB says enabled
- Ensure log file exists for LogWatcher to prevent disconnection

Fixes:
- "Failed to stop CrowdSec: 500 error" when toggling off
- CrowdSec showing "not running" despite being enabled in settings
- Live logs showing disconnected after container restart

2025-12-15 07:30:35 +00:00

4.8 KiB

Raw Blame History

QA Report: CrowdSec LAPI Availability Fix

Date: December 14, 2025 Agent: QA_Security Status: ✅ ALL CHECKS PASSED

Summary

Comprehensive QA testing was performed on the CrowdSec LAPI availability fix changes. All tests passed successfully.

Files Changed

backend/internal/api/handlers/crowdsec_exec.go - Stop() now idempotent
backend/internal/services/crowdsec_startup.go - NEW file for startup reconciliation
backend/internal/api/routes/routes.go - Added reconciliation call and log file creation
backend/internal/api/handlers/crowdsec_exec_test.go - Updated tests
backend/internal/services/crowdsec_startup_test.go - NEW test file

Test Results

1. Backend Build ✅

cd backend && go build ./...

Result: PASSED - No compilation errors

2. Backend Tests ✅

cd backend && go test ./...

Result: PASSED - All packages passed

Package	Status
`cmd/api`	✅ OK
`cmd/seed`	✅ OK (cached)
`internal/api/handlers`	✅ OK (84.579s)
`internal/api/middleware`	✅ OK
`internal/api/routes`	✅ OK
`internal/api/tests`	✅ OK
`internal/caddy`	✅ OK
`internal/cerberus`	✅ OK
`internal/config`	✅ OK (cached)
`internal/crowdsec`	✅ OK (12.710s)
`internal/database`	✅ OK (cached)
`internal/logger`	✅ OK (cached)
`internal/metrics`	✅ OK (cached)
`internal/models`	✅ OK (cached)
`internal/server`	✅ OK (cached)
`internal/services`	✅ OK (28.515s)
`internal/util`	✅ OK (cached)
`internal/version`	✅ OK (cached)

New CrowdSec Startup Tests Verified:

TestReconcileCrowdSecOnStartup_NilDB - PASS
TestReconcileCrowdSecOnStartup_NilExecutor - PASS
TestReconcileCrowdSecOnStartup_NoSecurityConfig - PASS
TestReconcileCrowdSecOnStartup_ModeDisabled - PASS
TestReconcileCrowdSecOnStartup_ModeLocal_AlreadyRunning - PASS
TestReconcileCrowdSecOnStartup_ModeLocal_NotRunning_Starts - PASS
TestReconcileCrowdSecOnStartup_ModeLocal_StartError - PASS
TestReconcileCrowdSecOnStartup_StatusError - PASS

3. Backend Lint (go vet) ✅

cd backend && go vet ./...

Result: PASSED - No lint errors

4. Frontend Type Check ✅

cd frontend && npm run type-check

Result: PASSED - No TypeScript errors

5. Frontend Lint ✅

cd frontend && npm run lint

Result: PASSED - 0 errors, 6 warnings (pre-existing, not related to changes)

File	Warning	Type
`e2e/tests/security-mobile.spec.ts:289`	Unused variable 'onclick'	@typescript-eslint/no-unused-vars
`src/pages/CrowdSecConfig.tsx:234`	Missing useEffect dependencies	react-hooks/exhaustive-deps
`src/pages/CrowdSecConfig.tsx:813`	Unexpected any type	@typescript-eslint/no-explicit-any
`src/pages/__tests__/CrowdSecConfig.spec.tsx`	3x Unexpected any type	@typescript-eslint/no-explicit-any

Note: These warnings are pre-existing and not related to the CrowdSec fix changes.

6. Frontend Tests ✅

cd frontend && npm run test

Result: PASSED

Test Files: 87 passed
Tests: 799 passed, 2 skipped
Duration: 61.67s

7. Pre-commit Checks ✅

source .venv/bin/activate && pre-commit run --all-files

Result: ALL PASSED

Check	Status
Go Vet	✅ Passed
Check .version matches latest Git tag	✅ Passed
Prevent large files	✅ Passed
Prevent CodeQL DB commits	✅ Passed
Prevent data/backups commits	✅ Passed
Frontend TypeScript Check	✅ Passed
Frontend Lint (Fix)	✅ Passed

Coverage: 85.1% (minimum required: 85%) ✅

Security Considerations

The CrowdSec changes were reviewed for security implications:

Idempotent Stop(): The Stop() function now safely handles cases where CrowdSec is not running, preventing potential panics or undefined behavior.
Startup Reconciliation: The new startup reconciliation ensures CrowdSec state is consistent after server restarts, preventing security gaps where CrowdSec might be expected to be running but isn't.
Log File Creation: Proper log file creation on startup ensures logging works correctly from the first request.

Conclusion

All QA checks have passed successfully. The CrowdSec LAPI availability fix is ready for merge:

✅ Backend compiles without errors
✅ All backend unit tests pass (including 8 new startup reconciliation tests)
✅ Backend passes lint checks
✅ Frontend passes TypeScript checks
✅ Frontend passes lint (no new warnings)
✅ All 799 frontend tests pass
✅ Pre-commit hooks pass
✅ Code coverage meets minimum threshold (85.1% >= 85%)

Recommendation: Approved for merge.

Report generated by QA_Security agent

4.8 KiB Raw Blame History