Files
Charon/frontend/src/pages/Notifications.tsx
GitHub Actions ed89295012 feat: wire MailService into notification dispatch pipeline (Stage 3)
Unifies the two previously independent email subsystems — MailService
(net/smtp transport) and NotificationService (HTTP-based providers) —
so email can participate in the notification dispatch pipeline.

Key changes:
- SendEmail signature updated to accept context.Context and []string
  recipients to enable timeout propagation and multi-recipient dispatch
- NotificationService.dispatchEmail() wires MailService as a first-class
  provider type with IsConfigured() guard and 30s context timeout
- 'email' added to isSupportedNotificationProviderType() and
  supportsJSONTemplates() returns false for email (plain/HTML only)
- settings_handler.go test-email endpoint updated to new SendEmail API
- Frontend: 'email' added to provider type union in notifications.ts,
  Notifications.tsx shows recipient field and hides URL/token fields for
  email providers
- All existing tests updated to match new SendEmail signature
- New tests added covering dispatchEmail paths, IsConfigured guards,
  recipient validation, and context timeout behaviour

Also fixes confirmed false-positive CodeQL go/email-injection alerts:
- smtp.SendMail, sendSSL w.Write, and sendSTARTTLS w.Write sites now
  carry inline codeql[go/email-injection] annotations as required by the
  CodeQL same-line suppression spec; preceding-line annotations silently
  no-op in current CodeQL versions
- auth_handler.go c.SetCookie annotated for intentional Secure=false on
  local non-HTTPS loopback (go/cookie-secure-not-set warning only)

Closes part of #800
2026-03-06 02:06:49 +00:00

732 lines
35 KiB
TypeScript

import { useEffect, useState, type FC } from 'react';
import { useTranslation } from 'react-i18next';
import { useQuery, useMutation, useQueryClient } from '@tanstack/react-query';
import { getProviders, createProvider, updateProvider, deleteProvider, testProvider, getTemplates, previewProvider, NotificationProvider, getExternalTemplates, previewExternalTemplate, ExternalTemplate, createExternalTemplate, updateExternalTemplate, deleteExternalTemplate, NotificationTemplate, SUPPORTED_NOTIFICATION_PROVIDER_TYPES, type SupportedNotificationProviderType } from '../api/notifications';
import { Card } from '../components/ui/Card';
import { Button } from '../components/ui/Button';
import { Bell, Plus, Trash2, Edit2, Send, Check, X, Loader2 } from 'lucide-react';
import { useForm } from 'react-hook-form';
import { toast } from '../utils/toast';
const DISCORD_PROVIDER_TYPE: SupportedNotificationProviderType = 'discord';
const isSupportedProviderType = (providerType: string | undefined): providerType is SupportedNotificationProviderType => {
if (!providerType) {
return false;
}
return SUPPORTED_NOTIFICATION_PROVIDER_TYPES.includes(providerType.toLowerCase() as SupportedNotificationProviderType);
};
// supportsJSONTemplates returns true if the provider type can use JSON templates
const supportsJSONTemplates = (providerType: string | undefined): boolean => {
if (!providerType) return false;
const t = providerType.toLowerCase();
return t === 'discord' || t === 'gotify' || t === 'webhook';
};
const isUnsupportedProviderType = (providerType: string | undefined): boolean => !isSupportedProviderType(providerType);
const normalizeProviderType = (providerType: string | undefined): SupportedNotificationProviderType => {
if (!isSupportedProviderType(providerType)) {
return DISCORD_PROVIDER_TYPE;
}
return providerType.toLowerCase() as SupportedNotificationProviderType;
};
const normalizeProviderPayloadForSubmit = (data: Partial<NotificationProvider>): Partial<NotificationProvider> => {
const type = normalizeProviderType(data.type);
const payload: Partial<NotificationProvider> = {
...data,
type,
};
if (type === 'gotify') {
const normalizedToken = typeof payload.gotify_token === 'string' ? payload.gotify_token.trim() : '';
if (normalizedToken.length > 0) {
payload.token = normalizedToken;
} else {
delete payload.token;
}
} else {
delete payload.token;
}
delete payload.gotify_token;
return payload;
};
const defaultProviderValues: Partial<NotificationProvider> = {
type: DISCORD_PROVIDER_TYPE,
enabled: true,
config: '',
gotify_token: '',
template: 'minimal',
notify_proxy_hosts: true,
notify_remote_servers: true,
notify_domains: true,
notify_certs: true,
notify_uptime: true,
notify_security_waf_blocks: false,
notify_security_acl_denies: false,
notify_security_rate_limit_hits: false,
};
const ProviderForm: FC<{
initialData?: Partial<NotificationProvider>;
onClose: () => void;
onSubmit: (data: Partial<NotificationProvider>) => void;
}> = ({ initialData, onClose, onSubmit }) => {
const { t } = useTranslation();
const { register, handleSubmit, watch, setValue, reset, formState: { errors } } = useForm({
defaultValues: defaultProviderValues,
});
const [testStatus, setTestStatus] = useState<'idle' | 'success' | 'error'>('idle');
const [previewContent, setPreviewContent] = useState<string | null>(null);
const [previewError, setPreviewError] = useState<string | null>(null);
useEffect(() => {
// Reset form state per open/edit to avoid event checkbox leakage between runs.
const normalizedInitialData = initialData
? { ...defaultProviderValues, ...initialData, type: normalizeProviderType(initialData.type), gotify_token: '' }
: defaultProviderValues;
reset(normalizedInitialData);
setTestStatus('idle');
setPreviewContent(null);
setPreviewError(null);
}, [initialData, reset]);
const testMutation = useMutation({
mutationFn: testProvider,
onSuccess: () => {
setTestStatus('success');
setTimeout(() => setTestStatus('idle'), 3000);
},
onError: (err: Error) => {
setTestStatus('error');
toast.error(err.message || t('notificationProviders.testFailed'));
setTimeout(() => setTestStatus('idle'), 3000);
}
});
const handleTest = () => {
const formData = watch();
testMutation.mutate({ ...formData, type: normalizeProviderType(formData.type) } as Partial<NotificationProvider>);
};
const handlePreview = async () => {
const formData = watch();
setPreviewContent(null);
setPreviewError(null);
try {
// If using an external saved template (id), call previewExternalTemplate with template_id
if (formData.template && typeof formData.template === 'string' && formData.template.length === 36) {
const res = await previewExternalTemplate(formData.template, undefined, undefined);
if (res.parsed) setPreviewContent(JSON.stringify(res.parsed, null, 2)); else setPreviewContent(res.rendered);
} else {
const res = await previewProvider({ ...formData, type: normalizeProviderType(formData.type) } as Partial<NotificationProvider>);
if (res.parsed) setPreviewContent(JSON.stringify(res.parsed, null, 2)); else setPreviewContent(res.rendered);
}
} catch (err: unknown) {
const msg = err instanceof Error ? err.message : String(err);
setPreviewError(msg || 'Failed to generate preview');
}
};
const type = normalizeProviderType(watch('type'));
const isGotify = type === 'gotify';
const isEmail = type === 'email';
useEffect(() => {
if (type !== 'gotify') {
setValue('gotify_token', '', { shouldDirty: false, shouldTouch: false });
}
}, [type, setValue]);
const { data: builtins } = useQuery({ queryKey: ['notificationTemplates'], queryFn: getTemplates });
const { data: externalTemplates } = useQuery({ queryKey: ['externalTemplates'], queryFn: getExternalTemplates });
const template = watch('template');
const setTemplate = (templateStr: string, templateName?: string) => {
// If templateName is provided, set template selection as well
if (templateName) setValue('template', templateName);
setValue('config', templateStr);
};
// Client-side URL validation keeps the form open and prevents navigation on invalid input.
const validateUrl = (value: string | undefined) => {
if (!value) return true;
try {
const parsed = new URL(value);
if (parsed.protocol !== 'http:' && parsed.protocol !== 'https:') {
return t('notificationProviders.invalidUrl');
}
return true;
} catch {
return t('notificationProviders.invalidUrl');
}
};
return (
<form onSubmit={handleSubmit((data) => onSubmit(normalizeProviderPayloadForSubmit(data as Partial<NotificationProvider>)))} className="space-y-4">
<div>
<label htmlFor="provider-name" className="block text-sm font-medium text-gray-700 dark:text-gray-300">{t('notificationProviders.providerName')} <span aria-hidden="true">*</span></label>
<input
id="provider-name"
{...register('name', { required: t('errors.required') as string })}
data-testid="provider-name"
className="mt-1 block w-full rounded-md border-gray-300 shadow-sm focus:border-blue-500 focus:ring-blue-500 dark:bg-gray-700 dark:border-gray-600 dark:text-white sm:text-sm"
aria-invalid={errors.name ? 'true' : 'false'}
/>
{errors.name && <span className="text-red-500 text-xs">{errors.name.message as string}</span>}
</div>
<div>
<label htmlFor="provider-type" className="block text-sm font-medium text-gray-700 dark:text-gray-300">{t('common.type')}</label>
<select
id="provider-type"
{...register('type')}
data-testid="provider-type"
className="mt-1 block w-full rounded-md border-gray-300 shadow-sm focus:border-blue-500 focus:ring-blue-500 dark:bg-gray-700 dark:border-gray-600 dark:text-white sm:text-sm"
>
<option value="discord">Discord</option>
<option value="gotify">Gotify</option>
<option value="webhook">{t('notificationProviders.genericWebhook')}</option>
<option value="email">Email</option>
</select>
</div>
<div>
<label htmlFor="provider-url" className="block text-sm font-medium text-gray-700 dark:text-gray-300">
{isEmail ? t('notificationProviders.recipients') : <>{t('notificationProviders.urlWebhook')} <span aria-hidden="true">*</span></>}
</label>
{isEmail && (
<p id="email-recipients-help" className="text-xs text-gray-500 mt-0.5">
{t('notificationProviders.recipientsHelp')}
</p>
)}
<input
id="provider-url"
{...register('url', {
required: isEmail ? false : (t('notificationProviders.urlRequired') as string),
validate: isEmail ? undefined : validateUrl,
})}
data-testid="provider-url"
placeholder={isEmail ? 'user@example.com, admin@example.com' : type === 'discord' ? 'https://discord.com/api/webhooks/...' : type === 'gotify' ? 'https://gotify.example.com/message' : 'https://example.com/webhook'}
className={`mt-1 block w-full rounded-md border-gray-300 shadow-sm focus:border-blue-500 focus:ring-blue-500 dark:bg-gray-700 dark:border-gray-600 dark:text-white sm:text-sm ${errors.url ? 'border-red-500' : ''}`}
aria-invalid={errors.url ? 'true' : 'false'}
aria-describedby={isEmail ? 'email-recipients-help' : errors.url ? 'provider-url-error' : undefined}
/>
{!isEmail && errors.url && (
<span id="provider-url-error" data-testid="provider-url-error" className="text-red-500 text-xs">
{errors.url.message as string}
</span>
)}
</div>
{isEmail && (
<div role="note" className="rounded-md bg-blue-50 dark:bg-blue-900/20 border border-blue-200 dark:border-blue-800 p-3">
<p className="text-sm text-blue-800 dark:text-blue-200">
{t('notificationProviders.emailSmtpNotice')}
</p>
</div>
)}
{isGotify && (
<div>
<label htmlFor="provider-gotify-token" className="block text-sm font-medium text-gray-700 dark:text-gray-300">
{t('notificationProviders.gotifyToken')}
</label>
<input
id="provider-gotify-token"
type="password"
autoComplete="new-password"
{...register('gotify_token')}
data-testid="provider-gotify-token"
placeholder={initialData?.has_token ? t('notificationProviders.gotifyTokenKeepPlaceholder') : t('notificationProviders.gotifyTokenPlaceholder')}
className="mt-1 block w-full rounded-md border-gray-300 shadow-sm focus:border-blue-500 focus:ring-blue-500 dark:bg-gray-700 dark:border-gray-600 dark:text-white sm:text-sm"
aria-describedby={initialData?.has_token ? 'gotify-token-stored-hint' : undefined}
/>
{initialData?.has_token && (
<p id="gotify-token-stored-hint" data-testid="gotify-token-stored-indicator" className="text-xs text-green-600 dark:text-green-400 mt-1">
{t('notificationProviders.gotifyTokenStored')}
</p>
)}
<p className="text-xs text-gray-500 mt-1">{t('notificationProviders.gotifyTokenWriteOnlyHint')}</p>
</div>
)}
{supportsJSONTemplates(type) && (
<div>
<label className="block text-sm font-medium text-gray-700 dark:text-gray-300">{t('notificationProviders.jsonPayloadTemplate')}</label>
<div className="flex gap-2 mb-2 mt-1">
<Button type="button" size="sm" variant={template === 'minimal' ? 'primary' : 'secondary'} onClick={() => setTemplate('{"message": "{{.Message}}", "title": "{{.Title}}", "time": "{{.Time}}", "event": "{{.EventType}}"}', 'minimal')}>
{t('notificationProviders.minimalTemplate')}
</Button>
<Button type="button" size="sm" variant={template === 'detailed' ? 'primary' : 'secondary'} onClick={() => setTemplate(`{"title": "{{.Title}}", "message": "{{.Message}}", "time": "{{.Time}}", "event": "{{.EventType}}", "host": "{{.HostName}}", "host_ip": "{{.HostIP}}", "service_count": {{.ServiceCount}}, "services": {{.Services}}}`, 'detailed')}>
{t('notificationProviders.detailedTemplate')}
</Button>
<Button type="button" size="sm" variant={template === 'custom' ? 'primary' : 'secondary'} onClick={() => setValue('template', 'custom')}>
{t('notificationProviders.customTemplate')}
</Button>
</div>
<div className="mt-2">
<label className="block text-sm font-medium text-gray-700 dark:text-gray-300">{t('notificationProviders.template')}</label>
<select {...register('template')} className="mt-1 block w-full rounded-md border-gray-300 shadow-sm focus:border-blue-500 focus:ring-blue-500 dark:bg-gray-700 dark:border-gray-600 dark:text-white sm:text-sm">
{/* Built-in template options */}
{builtins?.map((t: NotificationTemplate) => (
<option key={t.id} value={t.id}>{t.name}</option>
))}
{/* External saved templates (id values are UUIDs) */}
{externalTemplates?.map((t: ExternalTemplate) => (
<option key={t.id} value={t.id}>{t.name}</option>
))}
</select>
</div>
<textarea
{...register('config')}
data-testid="provider-config"
rows={8}
className="mt-1 block w-full font-mono text-xs rounded-md border-gray-300 shadow-sm focus:border-blue-500 focus:ring-blue-500 dark:bg-gray-700 dark:border-gray-600 dark:text-white"
placeholder='{"text": "{{.Message}}"}'
/>
<p className="text-xs text-gray-500 mt-1">
{t('notificationProviders.availableVariables')}
</p>
</div>
)}
<div className="space-y-2 border-t border-gray-200 dark:border-gray-700 pt-4">
<h4 className="text-sm font-medium text-gray-900 dark:text-white">{t('notificationProviders.notificationEvents')}</h4>
<div className="grid grid-cols-2 gap-2">
<div className="flex items-center">
<input type="checkbox" {...register('notify_proxy_hosts')} data-testid="notify-proxy-hosts" className="h-4 w-4 text-blue-600 focus:ring-blue-500 border-gray-300 rounded" />
<label className="ml-2 block text-sm text-gray-700 dark:text-gray-300">{t('notificationProviders.proxyHosts')}</label>
</div>
<div className="flex items-center">
<input type="checkbox" {...register('notify_remote_servers')} data-testid="notify-remote-servers" className="h-4 w-4 text-blue-600 focus:ring-blue-500 border-gray-300 rounded" />
<label className="ml-2 block text-sm text-gray-700 dark:text-gray-300">{t('notificationProviders.remoteServers')}</label>
</div>
<div className="flex items-center">
<input type="checkbox" {...register('notify_domains')} data-testid="notify-domains" className="h-4 w-4 text-blue-600 focus:ring-blue-500 border-gray-300 rounded" />
<label className="ml-2 block text-sm text-gray-700 dark:text-gray-300">{t('notificationProviders.domainsNotify')}</label>
</div>
<div className="flex items-center">
<input type="checkbox" {...register('notify_certs')} data-testid="notify-certs" className="h-4 w-4 text-blue-600 focus:ring-blue-500 border-gray-300 rounded" />
<label className="ml-2 block text-sm text-gray-700 dark:text-gray-300">{t('notificationProviders.certificates')}</label>
</div>
<div className="flex items-center">
<input type="checkbox" {...register('notify_uptime')} data-testid="notify-uptime" className="h-4 w-4 text-blue-600 focus:ring-blue-500 border-gray-300 rounded" />
<label className="ml-2 block text-sm text-gray-700 dark:text-gray-300">{t('notificationProviders.uptime')}</label>
</div>
</div>
<div className="pt-2">
<h5 className="text-sm font-medium text-gray-900 dark:text-white">{t('notificationProviders.securityEventSubscriptions')}</h5>
<p className="text-xs text-gray-500 mt-0.5">{t('notificationProviders.securityEventSubscriptionsHelp')}</p>
</div>
<div className="grid grid-cols-1 gap-2">
<div className="flex items-center">
<input type="checkbox" {...register('notify_security_waf_blocks')} data-testid="notify-security-waf-blocks" className="h-4 w-4 text-blue-600 focus:ring-blue-500 border-gray-300 rounded" />
<label className="ml-2 block text-sm text-gray-700 dark:text-gray-300">{t('notificationProviders.wafBlocks')}</label>
</div>
<div className="flex items-center">
<input type="checkbox" {...register('notify_security_acl_denies')} data-testid="notify-security-acl-denies" className="h-4 w-4 text-blue-600 focus:ring-blue-500 border-gray-300 rounded" />
<label className="ml-2 block text-sm text-gray-700 dark:text-gray-300">{t('notificationProviders.aclDenials')}</label>
</div>
<div className="flex items-center">
<input type="checkbox" {...register('notify_security_rate_limit_hits')} data-testid="notify-security-rate-limit-hits" className="h-4 w-4 text-blue-600 focus:ring-blue-500 border-gray-300 rounded" />
<label className="ml-2 block text-sm text-gray-700 dark:text-gray-300">{t('notificationProviders.rateLimitHits')}</label>
</div>
</div>
</div>
<div className="flex items-center">
<input
type="checkbox"
{...register('enabled')}
data-testid="provider-enabled"
className="h-4 w-4 text-blue-600 focus:ring-blue-500 border-gray-300 rounded"
/>
<label className="ml-2 block text-sm text-gray-900 dark:text-gray-300">{t('common.enabled')}</label>
</div>
<div className="flex justify-end gap-2 pt-4">
<Button variant="secondary" onClick={onClose}>{t('common.cancel')}</Button>
<Button
type="button"
variant="secondary"
onClick={handlePreview}
disabled={testMutation.isPending}
data-testid="provider-preview-btn"
className="min-w-20"
>
{t('notificationProviders.preview')}
</Button>
<Button
type="button"
variant="secondary"
onClick={handleTest}
disabled={testMutation.isPending}
data-testid="provider-test-btn"
className="min-w-20"
>
{testMutation.isPending ? <Loader2 className="w-4 h-4 animate-spin mx-auto" /> :
testStatus === 'success' ? <Check className="w-4 h-4 text-green-500 mx-auto" /> :
testStatus === 'error' ? <X className="w-4 h-4 text-red-500 mx-auto" /> :
t('common.test')}
</Button>
<Button type="submit" data-testid="provider-save-btn">{t('common.save')}</Button>
</div>
{previewError && <div className="mt-2 text-sm text-red-600">{t('notificationProviders.previewError')}: {previewError}</div>}
{previewContent && (
<div className="mt-2">
<label className="block text-sm font-medium text-gray-700 dark:text-gray-300">{t('notificationProviders.previewResult')}</label>
<pre className="mt-1 p-2 bg-gray-50 dark:bg-gray-800 rounded text-xs overflow-auto whitespace-pre-wrap">{previewContent}</pre>
</div>
)}
</form>
);
};
const TemplateForm: FC<{
initialData?: Partial<ExternalTemplate>;
onClose: () => void;
onSubmit: (data: Partial<ExternalTemplate>) => void;
}> = ({ initialData, onClose, onSubmit }) => {
const { t } = useTranslation();
const { register, handleSubmit, watch } = useForm({
defaultValues: initialData || { template: 'custom', config: '' }
});
const [preview, setPreview] = useState<string | null>(null);
const [previewErr, setPreviewErr] = useState<string | null>(null);
const handlePreview = async () => {
setPreview(null);
setPreviewErr(null);
const form = watch();
try {
const res = await previewExternalTemplate(undefined, form.config, { Title: 'Preview Title', Message: 'Preview Message', Time: new Date().toISOString(), EventType: 'preview' });
if (res.parsed) setPreview(JSON.stringify(res.parsed, null, 2)); else setPreview(res.rendered);
} catch (err: unknown) {
const msg = err instanceof Error ? err.message : String(err);
setPreviewErr(msg || 'Preview failed');
}
};
return (
<form onSubmit={handleSubmit(onSubmit)} className="space-y-3">
<div>
<label htmlFor="template-name" className="block text-sm font-medium text-gray-700 dark:text-gray-300">{t('common.name')}</label>
<input id="template-name" data-testid="template-name" {...register('name', { required: true })} className="mt-1 block w-full rounded-md" />
</div>
<div>
<label htmlFor="template-description" className="block text-sm font-medium text-gray-700 dark:text-gray-300">{t('common.description')}</label>
<input id="template-description" data-testid="template-description" {...register('description')} className="mt-1 block w-full rounded-md" />
</div>
<div>
<label htmlFor="template-type" className="block text-sm font-medium text-gray-700 dark:text-gray-300">{t('notificationProviders.templateType')}</label>
<select id="template-type" data-testid="template-type" {...register('template')} className="mt-1 block w-full rounded-md">
<option value="minimal">{t('notificationProviders.minimal')}</option>
<option value="detailed">{t('notificationProviders.detailed')}</option>
<option value="custom">{t('notificationProviders.custom')}</option>
</select>
</div>
<div>
<label htmlFor="template-config" className="block text-sm font-medium text-gray-700 dark:text-gray-300">{t('notificationProviders.configJson')}</label>
<textarea id="template-config" data-testid="template-config" {...register('config')} rows={6} className="mt-1 block w-full font-mono text-xs rounded-md" />
</div>
<div className="flex justify-end gap-2">
<Button variant="secondary" onClick={onClose} data-testid="template-cancel-btn">{t('common.cancel')}</Button>
<Button type="button" variant="secondary" onClick={handlePreview} data-testid="template-preview-btn">{t('notificationProviders.preview')}</Button>
<Button type="submit" data-testid="template-save-btn">{t('common.save')}</Button>
</div>
{previewErr && <div className="text-sm text-red-600">{previewErr}</div>}
{preview && (
<div>
<label className="block text-sm font-medium text-gray-700 dark:text-gray-300">{t('notificationProviders.preview')}</label>
<pre className="mt-1 p-2 bg-gray-50 dark:bg-gray-800 rounded text-xs overflow-auto whitespace-pre-wrap">{preview}</pre>
</div>
)}
</form>
);
};
const Notifications: FC = () => {
const { t } = useTranslation();
const queryClient = useQueryClient();
const [isAdding, setIsAdding] = useState(false);
const [editingId, setEditingId] = useState<string | null>(null);
const [managingTemplates, setManagingTemplates] = useState(false);
const [editingTemplateId, setEditingTemplateId] = useState<string | null>(null);
const [updateIndicatorId, setUpdateIndicatorId] = useState<string | null>(null);
const { data: providers, isLoading } = useQuery({
queryKey: ['notificationProviders'],
queryFn: getProviders,
});
const { data: externalTemplates, isLoading: externalTemplatesLoading } = useQuery({ queryKey: ['externalTemplates'], queryFn: getExternalTemplates });
const createMutation = useMutation({
mutationFn: createProvider,
onSuccess: () => {
queryClient.invalidateQueries({ queryKey: ['notificationProviders'] });
setIsAdding(false);
},
});
const updateMutation = useMutation({
mutationFn: ({ id, data }: { id: string; data: Partial<NotificationProvider> }) => updateProvider(id, data),
onSuccess: (_data, variables) => {
queryClient.invalidateQueries({ queryKey: ['notificationProviders'] });
setEditingId(null);
// Keep a deterministic update indicator for UI feedback and E2E stability.
setUpdateIndicatorId(variables.id);
toast.success(t('common.saved'));
},
});
useEffect(() => {
if (!updateIndicatorId) return;
const timer = window.setTimeout(() => setUpdateIndicatorId(null), 3000);
return () => window.clearTimeout(timer);
}, [updateIndicatorId]);
const deleteMutation = useMutation({
mutationFn: deleteProvider,
onSuccess: () => {
queryClient.invalidateQueries({ queryKey: ['notificationProviders'] });
},
});
const createTemplateMutation = useMutation({
mutationFn: (data: Partial<ExternalTemplate>) => createExternalTemplate(data),
onSuccess: () => queryClient.invalidateQueries({ queryKey: ['externalTemplates'] }),
});
const updateTemplateMutation = useMutation({
mutationFn: ({ id, data }: { id: string; data: Partial<ExternalTemplate> }) => updateExternalTemplate(id, data),
onSuccess: () => queryClient.invalidateQueries({ queryKey: ['externalTemplates'] }),
});
const deleteTemplateMutation = useMutation({
mutationFn: (id: string) => deleteExternalTemplate(id),
onSuccess: () => queryClient.invalidateQueries({ queryKey: ['externalTemplates'] }),
});
const testMutation = useMutation({
mutationFn: testProvider,
onSuccess: () => alert(t('notificationProviders.testSent')),
onError: (err: Error) => alert(`${t('notificationProviders.testFailed')}: ${err.message}`),
});
if (isLoading) return <div>{t('common.loading')}</div>;
return (
<div className="space-y-6">
<div className="flex justify-between items-center">
<h1 className="text-2xl font-bold text-gray-900 dark:text-white flex items-center gap-2">
<Bell className="w-6 h-6" />
{t('notificationProviders.title')}
</h1>
<Button onClick={() => setIsAdding(true)} data-testid="add-provider-btn">
<Plus className="w-4 h-4 mr-2" />
{t('notificationProviders.addProvider')}
</Button>
</div>
{/* External Templates Management */}
<div className="flex justify-between items-center">
<h2 className="text-xl font-semibold text-gray-900 dark:text-white">{t('notificationProviders.externalTemplates')}</h2>
<div className="flex items-center gap-2">
<Button onClick={() => setManagingTemplates(!managingTemplates)} variant="secondary" size="sm">
{managingTemplates ? t('notificationProviders.hideTemplates') : t('notificationProviders.manageTemplates')}
</Button>
<Button onClick={() => { setEditingTemplateId(null); setManagingTemplates(true); }}>
<Plus className="w-4 h-4 mr-2" />{t('notificationProviders.newTemplate')}
</Button>
</div>
</div>
{managingTemplates && (
<div className="space-y-4">
{/* Template Form area */}
{editingTemplateId !== null && (
<Card className="p-4">
<TemplateForm
initialData={externalTemplates?.find((t: ExternalTemplate) => t.id === editingTemplateId) as Partial<ExternalTemplate>}
onClose={() => setEditingTemplateId(null)}
onSubmit={(data) => {
if (editingTemplateId) updateTemplateMutation.mutate({ id: editingTemplateId, data });
else createTemplateMutation.mutate(data as Partial<ExternalTemplate>);
}}
/>
</Card>
)}
{/* Create new when editingTemplateId is null and Manage Templates open -> show form */}
{editingTemplateId === null && (
<Card className="p-4">
<h3 className="font-medium mb-2">{t('notificationProviders.createTemplate')}</h3>
<TemplateForm
onClose={() => setManagingTemplates(false)}
onSubmit={(data) => createTemplateMutation.mutate(data as Partial<ExternalTemplate>)}
/>
</Card>
)}
{/* List of templates */}
<div className="grid gap-3" data-testid="external-templates-list">
{externalTemplatesLoading && (
<div className="text-sm text-gray-500" data-testid="external-templates-loading">
{t('common.loading')}
</div>
)}
{externalTemplates?.map((t_template: ExternalTemplate) => (
<Card
key={t_template.id}
className="p-4 flex justify-between items-start"
data-testid={`external-template-row-${t_template.id}`}
>
<div>
<h4 className="font-medium text-gray-900 dark:text-white">{t_template.name}</h4>
<p className="text-sm text-gray-500 mt-1">{t_template.description}</p>
<pre className="mt-2 text-xs font-mono bg-gray-50 dark:bg-gray-800 p-2 rounded max-h-44 overflow-auto">{t_template.config}</pre>
</div>
<div className="flex flex-col gap-2 ml-4">
<Button size="sm" variant="secondary" onClick={() => setEditingTemplateId(t_template.id)} data-testid={`external-template-edit-${t_template.id}`}>
<Edit2 className="w-4 h-4" />
</Button>
{/* Stable test hook for async template list rendering. */}
<Button
size="sm"
variant="danger"
data-testid={`external-template-delete-${t_template.id}`}
onClick={() => { if (confirm(t('notificationProviders.deleteTemplateConfirm'))) deleteTemplateMutation.mutate(t_template.id); }}
>
<Trash2 className="w-4 h-4" />
</Button>
</div>
</Card>
))}
{externalTemplates?.length === 0 && (
<div className="text-sm text-gray-500">{t('notificationProviders.noExternalTemplates')}</div>
)}
</div>
</div>
)}
{isAdding && (
<Card className="p-6 mb-6 border-blue-500 border-2">
<h3 className="text-lg font-medium mb-4">{t('notificationProviders.addNewProvider')}</h3>
<ProviderForm
onClose={() => setIsAdding(false)}
onSubmit={(data) => createMutation.mutate(data)}
/>
</Card>
)}
<div className="grid gap-4">
{providers?.map((provider) => (
<Card key={provider.id} className="p-4" data-testid={`provider-row-${provider.id}`}>
{editingId === provider.id && !isUnsupportedProviderType(provider.type) ? (
<ProviderForm
initialData={provider}
onClose={() => setEditingId(null)}
onSubmit={(data) => updateMutation.mutate({ id: provider.id, data })}
/>
) : (
<div className="flex items-center justify-between">
<div className="flex items-center gap-4">
<div className={`p-2 rounded-full ${provider.enabled ? 'bg-green-100 text-green-600' : 'bg-gray-100 text-gray-400'}`}>
<Bell className="w-5 h-5" />
</div>
<div>
<h3 className="font-medium text-gray-900 dark:text-white">{provider.name}</h3>
{updateIndicatorId === provider.id && (
<span className="text-xs text-green-600" data-testid={`provider-update-indicator-${provider.id}`}>
{t('common.saved')}
</span>
)}
{isUnsupportedProviderType(provider.type) && (
<div className="mt-2 space-y-1">
<div className="flex flex-wrap items-center gap-2">
<span
className="text-xs font-semibold bg-amber-100 text-amber-800 dark:bg-amber-900 dark:text-amber-200 px-2 py-0.5 rounded"
data-testid={`provider-deprecated-status-${provider.id}`}
>
{t('notificationProviders.deprecatedReadOnly')}
</span>
<span
className="text-xs font-semibold bg-gray-200 text-gray-700 dark:bg-gray-700 dark:text-gray-200 px-2 py-0.5 rounded"
data-testid={`provider-nondispatch-status-${provider.id}`}
>
{t('notificationProviders.nonDispatch')}
</span>
</div>
<p
className="text-xs text-gray-600 dark:text-gray-300"
data-testid={`provider-deprecated-message-${provider.id}`}
>
{t('notificationProviders.deprecatedProviderMessage')}
</p>
</div>
)}
<div className="text-sm text-gray-500 dark:text-gray-400 flex items-center gap-2">
<span className="uppercase text-xs font-bold bg-gray-100 dark:bg-gray-700 px-2 py-0.5 rounded">
{provider.type}
</span>
<span className="truncate max-w-xs opacity-50">{provider.url}</span>
</div>
</div>
</div>
<div className="flex items-center gap-2">
{!isUnsupportedProviderType(provider.type) && (
<Button
variant="secondary"
size="sm"
onClick={() => testMutation.mutate({ ...provider, type: normalizeProviderType(provider.type) })}
isLoading={testMutation.isPending}
title={t('notificationProviders.sendTest')}
>
<Send className="w-4 h-4" />
</Button>
)}
{!isUnsupportedProviderType(provider.type) && (
<Button variant="secondary" size="sm" onClick={() => setEditingId(provider.id)}>
<Edit2 className="w-4 h-4" />
</Button>
)}
<Button
variant="danger"
size="sm"
onClick={() => {
if (confirm(t('notificationProviders.deleteConfirm'))) deleteMutation.mutate(provider.id);
}}
>
<Trash2 className="w-4 h-4" />
</Button>
</div>
</div>
)}
</Card>
))}
{providers?.length === 0 && !isAdding && (
<div className="text-center py-12 text-gray-500 bg-gray-50 dark:bg-gray-800 rounded-lg border-2 border-dashed border-gray-200 dark:border-gray-700">
{t('notificationProviders.noProviders')}
</div>
)}
</div>
</div>
);
};
export default Notifications;