Files

GitHub Actions c3b20bff65 test: implement Caddy import E2E gap tests

Add 11 Playwright E2E tests covering Caddy import functionality gaps:

Success modal navigation and button actions (Gap 1)
Conflict details expansion with side-by-side comparison (Gap 2)
Overwrite resolution flow for existing hosts (Gap 3)
Session resume via banner (Gap 4 - skipped, documented limitation)
Custom name editing in review table (Gap 5)
Fixes:

backend/internal/caddy/importer.go: Handle errcheck lint errors
Result: 9 tests passing, 2 skipped with documented reason

2026-01-31 02:15:13 +00:00

2.2 KiB

Raw Blame History

Docker Compose CI Fix - Quick Reference

Document: Full Remediation Plan Status: Ready for Implementation Priority: CRITICAL

Problem

E2E tests failing with:

charon-app Error pull access denied for sha256, repository does not exist

Root Cause

The workflow passes bare SHA256 digest to Docker Compose:

CHARON_E2E_IMAGE_DIGEST: sha256:057a9998...

Docker tries to pull from a repository named "sha256" (doesn't exist).

Solution

Use the local tag that already exists after docker load:

Change 1: Workflow

File: .github/workflows/e2e-tests.yml (line 158)

- CHARON_E2E_IMAGE_DIGEST: ${{ needs.build.outputs.image_digest }}
+ # Use local tag for pre-built image (loaded from artifact)
+ CHARON_E2E_IMAGE: charon:e2e-test

Change 2: Compose File

File: .docker/compose/docker-compose.playwright-ci.yml (lines 31-37)

- # CI default (digest-pinned via workflow output):
- # CHARON_E2E_IMAGE_DIGEST=ghcr.io/wikid82/charon:nightly@sha256:<digest>
- # Local override (tag-based):
+ # CI default: Uses pre-built image loaded from artifact
+ # Set via workflow: CHARON_E2E_IMAGE=charon:e2e-test
+ # Local development: Uses locally built image
+ # Override with: CHARON_E2E_IMAGE=charon:local-dev
- image: ${CHARON_E2E_IMAGE_DIGEST:-${CHARON_E2E_IMAGE:-charon:e2e-test}}
+ image: ${CHARON_E2E_IMAGE:-charon:e2e-test}

Why This Works

Step	Current (Broken)	Fixed
Build	Tags as `charon:e2e-test`	Same
Load	Image available as `charon:e2e-test`	Same
Compose	Tries to use `sha256:...` ❌	Uses `charon:e2e-test` ✅

Verification

# After changes, run locally:
export CHARON_E2E_IMAGE=charon:e2e-test
docker compose -f .docker/compose/docker-compose.playwright-ci.yml config | grep "image:"

# Should output:
# image: charon:e2e-test

Testing

Create PR with both changes
Monitor e2e-tests.yml workflow
Verify "Start test environment" step succeeds
Confirm health check passes

See docker_compose_ci_fix.md for full analysis and implementation details.

2.2 KiB Raw Blame History