akanealw/Charon

Files

GitHub Actions 032d475fba chore: remediate 61 Go linting issues and tighten pre-commit config

Complete lint remediation addressing errcheck, gosec, and staticcheck
violations across backend test files. Tighten pre-commit configuration
to prevent future blind spots.

Key Changes:
- Fix 61 Go linting issues (errcheck, gosec G115/G301/G304/G306, bodyclose)
- Add proper error handling for json.Unmarshal, os.Setenv, db.Close(), w.Write()
- Fix gosec G115 integer overflow with strconv.FormatUint
- Add #nosec annotations with justifications for test fixtures
- Fix SecurityService goroutine leaks (add Close() calls)
- Fix CrowdSec tar.gz non-deterministic ordering with sorted keys

Pre-commit Hardening:
- Remove test file exclusion from golangci-lint hook
- Add gosec to .golangci-fast.yml with critical checks (G101, G110, G305)
- Replace broad .golangci.yml exclusions with targeted path-specific rules
- Test files now linted on every commit

Test Fixes:
- Fix emergency route count assertions (1→2 for dual-port setup)
- Fix DNS provider service tests with proper mock setup
- Fix certificate service tests with deterministic behavior

Backend: 27 packages pass, 83.5% coverage
Frontend: 0 lint warnings, 0 TypeScript errors
Pre-commit: All 14 hooks pass (~37s)

2026-02-02 06:17:48 +00:00

4.8 KiB

Raw Blame History

Manual Test Plan: E2E Feature Flags Timeout Fix

Created: 2026-02-02 Priority: P1 - High Type: Manual Testing Component: E2E Tests, Feature Flags API Related PR: #583

Objective

Manually verify the E2E test timeout fix implementation works correctly in a real CI environment after resolving the Playwright infrastructure issue.

Prerequisites

Playwright deduplication issue resolved: rm -rf node_modules && npm install && npm dedupe
E2E container rebuilt: .github/skills/scripts/skill-runner.sh docker-rebuild-e2e
Container health check passing: docker ps shows charon-e2e as healthy

Test Scenarios

1. Feature Flag Toggle Tests (Chromium)

File: tests/settings/system-settings.spec.ts

Execute:

npx playwright test tests/settings/system-settings.spec.ts --project=chromium --workers=1 --retries=0

Expected Results:

All 7 tests pass (4 refactored + 3 new)
Zero timeout errors
Test execution time: ≤5s per test
Console shows retry attempts (if transient failures occur)

Tests to Validate:

should toggle Cerberus security feature
should toggle CrowdSec console enrollment
should toggle uptime monitoring
should persist feature toggle changes
should handle concurrent toggle operations
should retry on 500 Internal Server Error
should fail gracefully after max retries exceeded

2. Cross-Browser Validation

Execute:

npx playwright test tests/settings/system-settings.spec.ts --project=chromium --project=firefox --project=webkit

Expected Results:

All browsers pass: Chromium, Firefox, WebKit
No browser-specific timeout issues
Consistent behavior across browsers

3. Performance Metrics Extraction

Execute:

docker logs charon-e2e 2>&1 | grep "\[METRICS\]"

Expected Results:

Metrics logged for GET operations: [METRICS] GET /feature-flags: {latency}ms
Metrics logged for PUT operations: [METRICS] PUT /feature-flags: {latency}ms
Latency values: <200ms P99 (CI environment)

4. Reliability Test (10 Consecutive Runs)

Execute:

for i in {1..10}; do
  echo "Run $i of 10"
  npx playwright test tests/settings/system-settings.spec.ts --project=chromium --workers=1 --retries=0
  if [ $? -ne 0 ]; then
    echo "FAILED on run $i"
    break
  fi
done

Expected Results:

10/10 runs pass (100% pass rate)
Zero timeout errors across all runs
Retry attempts: <5% of operations

5. UI Verification

Manual Steps:

Navigate to /settings/system in browser
Toggle Cerberus security feature switch
Verify toggle animation completes
Verify "Saved" notification appears
Refresh page
Verify toggle state persists

Expected Results:

UI responsive (<1s toggle feedback)
State changes reflect immediately
No console errors

Bug Discovery Focus

Look for potential issues in:

Backend Performance

Feature flags endpoint latency spikes (>500ms)
Database lock timeouts
Transaction rollback failures
Memory leaks after repeated toggles

Test Resilience

Retry logic not triggering on transient failures
Polling timeouts on slow CI runners
Race conditions in concurrent toggle test
Hard-coded wait remnants causing flakiness

Edge Cases

Concurrent toggles causing data corruption
Network failures not handled gracefully
Max retries not throwing expected error
Initial state mismatch in beforeEach

Success Criteria

All 35 checks above pass without issues
Zero timeout errors in 10 consecutive runs
Performance metrics confirm <200ms P99 latency
Cross-browser compatibility verified
No new bugs discovered during manual testing

Failure Handling

If any test fails:

Capture Evidence:
- Screenshot of failure
- Full test output (no truncation)
- docker logs charon-e2e output
- Network/console logs from browser DevTools
Analyze Root Cause:
- Is it a code defect or infrastructure issue?
- Is it reproducible locally?
- Does it happen in all browsers?
Take Action:
- Code Defect: Reopen issue, describe failure, assign to developer
- Infrastructure: Document in known issues, create follow-up ticket
- Flaky Test: Investigate retry logic, increase timeouts if justified

Notes

Run tests during low CI load times for accurate performance measurement
Use --headed flag for UI verification: npx playwright test --headed
Check Playwright trace if tests fail: npx playwright show-report

Assigned To: QA Team Estimated Time: 2-3 hours Due Date: Within 24 hours of Playwright infrastructure fix