Some checks are pending
Go Benchmark / Performance Regression Check (push) Waiting to run
Cerberus Integration / Cerberus Security Stack Integration (push) Waiting to run
Upload Coverage to Codecov / Backend Codecov Upload (push) Waiting to run
Upload Coverage to Codecov / Frontend Codecov Upload (push) Waiting to run
CodeQL - Analyze / CodeQL analysis (go) (push) Waiting to run
CodeQL - Analyze / CodeQL analysis (javascript-typescript) (push) Waiting to run
CrowdSec Integration / CrowdSec Bouncer Integration (push) Waiting to run
Docker Build, Publish & Test / build-and-push (push) Waiting to run
Docker Build, Publish & Test / Security Scan PR Image (push) Blocked by required conditions
Quality Checks / Auth Route Protection Contract (push) Waiting to run
Quality Checks / Codecov Trigger/Comment Parity Guard (push) Waiting to run
Quality Checks / Backend (Go) (push) Waiting to run
Quality Checks / Frontend (React) (push) Waiting to run
Rate Limit integration / Rate Limiting Integration (push) Waiting to run
Security Scan (PR) / Trivy Binary Scan (push) Waiting to run
Supply Chain Verification (PR) / Verify Supply Chain (push) Waiting to run
WAF integration / Coraza WAF Integration (push) Waiting to run
3.1 KiB
Executable File
3.1 KiB
Executable File
Docs Workflow Update Plan
1. Introduction
The current documentation workflow only validates and deploys on pushes to main. This leaves other branches without validation of documentation changes, potentially leading to broken docs being merged. This plan outlines the updates to ensure documentation is built/validated on all relevant branches and PRs, while deployment remains restricted to main.
2. Research Findings
- Current File:
.github/workflows/docs.yml - Build Method: Uses
npm install -g markedto convert Markdown to HTML. - Deploy Method: Uses
actions/upload-pages-artifactandactions/deploy-pages. - Triggers: Currently limited to
push: branches: [main].
3. Technical Specifications
Workflow Triggers (on)
The workflow triggers need to be expanded to cover:
- Pull Requests targeting
mainordevelopment. - Pushes to
main,development,feature/**, andhotfix/**.
on:
push:
branches:
- main
- development
- 'feature/**'
- 'hotfix/**'
paths:
- 'docs/**'
- 'README.md'
- '.github/workflows/docs.yml'
pull_request:
branches:
- main
- development
paths:
- 'docs/**'
- 'README.md'
- '.github/workflows/docs.yml'
workflow_dispatch:
Concurrency
Update concurrency to be scoped by branch. This allows parallel builds for different feature branches.
Use cancel-in-progress: true for all branches except main to save resources on rapid fast-forward pushes, but ensure robust deployments for main.
concurrency:
group: "pages-${{ github.ref }}"
cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}
Job Constraints
- Job
build: Should run on all triggers. No changes needed to conditions. - Job
deploy: Must be restricted tomainbranch pushes only.
deploy:
name: Deploy to GitHub Pages
if: github.ref == 'refs/heads/main' && github.event_name == 'push'
environment:
name: github-pages
url: ${{ steps.deployment.outputs.page_url }}
runs-on: ubuntu-latest
timeout-minutes: 5
needs: build
# ... steps ...
4. Implementation Tasks
- Modify
.github/workflows/docs.yml:- Update
ontriggers. - Update
concurrencyblock withgroup: "pages-${{ github.ref }}"and conditionalcancel-in-progress. - Add
ifcondition todeployjob. - Fix 404 Link Error:
- Replace hardcoded
/charon/paths in generated HTML navigation with dynamic repository name variable. - Use
${{ github.event.repository.name }}within the workflow to construct the base path, ensuring case-sensitivity compatibility (e.g.,Charonvscharon).
- Replace hardcoded
- Update
5. Acceptance Criteria
- Pushing to a feature branch triggers the
buildjob but skipsdeploy. - Multiple feature branch pushes run in parallel (checked via Actions tab).
- Rapid pushes to the same feature branch cancel previous runs.
- Opening a PR triggers the
buildjob. - Pushing to
maintriggers bothbuildanddeploy. - Pushing to
maindoes not cancel in-progress runs (safe deployment).