name: Rate Limit integration # Phase 2-3: Build Once, Test Many - Use registry image instead of building # This workflow now waits for docker-build.yml to complete and pulls the built image on: workflow_dispatch: inputs: image_tag: description: 'Docker image tag to test (e.g., pr-123-abc1234, latest)' required: false type: string # Prevent race conditions when PR is updated mid-test # Cancels old test runs when new build completes with different SHA concurrency: group: ${{ github.workflow }}-${{ github.event.workflow_run.event || github.event_name }}-${{ github.event.workflow_run.head_branch || github.ref }} cancel-in-progress: true jobs: rate-limit-integration: name: Rate Limiting Integration runs-on: ubuntu-latest timeout-minutes: 15 # Only run if docker-build.yml succeeded, or if manually triggered if: ${{ github.event_name == 'workflow_dispatch' || (github.event_name == 'workflow_run' && (github.event.workflow_run.status != 'completed' || github.event.workflow_run.conclusion == 'success')) }} steps: - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6 # Determine the correct image tag based on trigger context # For PRs: pr-{number}-{short-sha}, For non-PR: sha-{short-sha} - name: Determine image tag id: determine-tag env: EVENT: ${{ github.event.workflow_run.event || github.event_name }} REF: ${{ github.event.workflow_run.head_branch || github.ref_name }} SHA: ${{ github.event.workflow_run.head_sha || github.sha }} MANUAL_TAG: ${{ inputs.image_tag }} run: | # Manual trigger uses provided tag if [[ "${{ github.event_name }}" == "workflow_dispatch" ]]; then if [[ -n "$MANUAL_TAG" ]]; then echo "tag=${MANUAL_TAG}" >> $GITHUB_OUTPUT else # Default to latest if no tag provided echo "tag=latest" >> $GITHUB_OUTPUT fi echo "source_type=manual" >> $GITHUB_OUTPUT exit 0 fi # Extract 7-character short SHA SHORT_SHA=$(echo "$SHA" | cut -c1-7) # Use native pull_requests array (no API calls needed) PR_NUM=$(echo '${{ toJson(github.event.workflow_run.pull_requests) }}' | jq -r '.[0].number // empty') if [[ "$EVENT" == "pull_request" || -n "$PR_NUM" ]]; then # Fallback for direct PR trigger if [[ -z "$PR_NUM" || "$PR_NUM" == "null" ]]; then PR_NUM="${{ github.event.number }}" fi if [[ -z "$PR_NUM" || "$PR_NUM" == "null" ]]; then echo "❌ ERROR: Could not determine PR number" echo "Event: $EVENT" echo "Ref: $REF" echo "SHA: $SHA" echo "Pull Requests JSON: ${{ toJson(github.event.workflow_run.pull_requests) }}" exit 1 fi # Immutable tag with SHA suffix prevents race conditions echo "tag=pr-${PR_NUM}-${SHORT_SHA}" >> $GITHUB_OUTPUT echo "source_type=pr" >> $GITHUB_OUTPUT else # Non-PR workflow_run uses short SHA tag (matches docker-build.yml) echo "tag=sha-${SHORT_SHA}" >> $GITHUB_OUTPUT echo "source_type=sha" >> $GITHUB_OUTPUT fi echo "sha=${SHORT_SHA}" >> $GITHUB_OUTPUT echo "Determined image tag: $(cat $GITHUB_OUTPUT | grep tag=)" # Pull image from Docker Hub with retry logic - name: Pull Docker image from registry id: pull_image uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 # v3 with: timeout_minutes: 5 max_attempts: 3 retry_wait_seconds: 10 command: | IMAGE_NAME="docker.io/wikid82/charon:${{ steps.determine-tag.outputs.tag }}" echo "Pulling image: $IMAGE_NAME" docker pull "$IMAGE_NAME" docker tag "$IMAGE_NAME" charon:local echo "✅ Successfully pulled from registry" # Validate image freshness by checking SHA label - name: Validate image SHA env: SHA: ${{ steps.determine-tag.outputs.sha }} run: | LABEL_SHA=$(docker inspect charon:local --format '{{index .Config.Labels "org.opencontainers.image.revision"}}' | cut -c1-7) echo "Expected SHA: $SHA" echo "Image SHA: $LABEL_SHA" if [[ "$LABEL_SHA" != "$SHA" ]]; then echo "⚠️ WARNING: Image SHA mismatch!" echo "Image may be stale. Proceeding with caution..." else echo "✅ Image SHA matches expected commit" fi - name: Run rate limit integration tests id: ratelimit-test run: | chmod +x scripts/rate_limit_integration.sh scripts/rate_limit_integration.sh 2>&1 | tee ratelimit-test-output.txt exit ${PIPESTATUS[0]} - name: Dump Debug Info on Failure if: failure() run: | echo "## 🔍 Debug Information" >> $GITHUB_STEP_SUMMARY echo "" >> $GITHUB_STEP_SUMMARY echo "### Container Status" >> $GITHUB_STEP_SUMMARY echo '```' >> $GITHUB_STEP_SUMMARY docker ps -a --filter "name=charon" --filter "name=ratelimit" --filter "name=backend" >> $GITHUB_STEP_SUMMARY 2>&1 || true echo '```' >> $GITHUB_STEP_SUMMARY echo "" >> $GITHUB_STEP_SUMMARY echo "### Security Config API" >> $GITHUB_STEP_SUMMARY echo '```json' >> $GITHUB_STEP_SUMMARY curl -s http://localhost:8280/api/v1/security/config 2>/dev/null | head -100 >> $GITHUB_STEP_SUMMARY || echo "Could not retrieve security config" >> $GITHUB_STEP_SUMMARY echo '```' >> $GITHUB_STEP_SUMMARY echo "" >> $GITHUB_STEP_SUMMARY echo "### Security Status API" >> $GITHUB_STEP_SUMMARY echo '```json' >> $GITHUB_STEP_SUMMARY curl -s http://localhost:8280/api/v1/security/status 2>/dev/null | head -100 >> $GITHUB_STEP_SUMMARY || echo "Could not retrieve security status" >> $GITHUB_STEP_SUMMARY echo '```' >> $GITHUB_STEP_SUMMARY echo "" >> $GITHUB_STEP_SUMMARY echo "### Caddy Admin Config (rate_limit handlers)" >> $GITHUB_STEP_SUMMARY echo '```json' >> $GITHUB_STEP_SUMMARY curl -s http://localhost:2119/config 2>/dev/null | grep -A 20 '"handler":"rate_limit"' | head -30 >> $GITHUB_STEP_SUMMARY || echo "Could not retrieve Caddy config" >> $GITHUB_STEP_SUMMARY echo '```' >> $GITHUB_STEP_SUMMARY echo "" >> $GITHUB_STEP_SUMMARY echo "### Charon Container Logs (last 100 lines)" >> $GITHUB_STEP_SUMMARY echo '```' >> $GITHUB_STEP_SUMMARY docker logs charon-ratelimit-test 2>&1 | tail -100 >> $GITHUB_STEP_SUMMARY || echo "No container logs available" >> $GITHUB_STEP_SUMMARY echo '```' >> $GITHUB_STEP_SUMMARY - name: Rate Limit Integration Summary if: always() run: | echo "## ⏱️ Rate Limit Integration Test Results" >> $GITHUB_STEP_SUMMARY if [ "${{ steps.ratelimit-test.outcome }}" == "success" ]; then echo "✅ **All rate limit tests passed**" >> $GITHUB_STEP_SUMMARY echo "" >> $GITHUB_STEP_SUMMARY echo "### Test Results:" >> $GITHUB_STEP_SUMMARY echo '```' >> $GITHUB_STEP_SUMMARY grep -E "✓|=== ALL|HTTP 429|HTTP 200" ratelimit-test-output.txt | head -30 || echo "See logs for details" grep -E "✓|=== ALL|HTTP 429|HTTP 200" ratelimit-test-output.txt | head -30 >> $GITHUB_STEP_SUMMARY || echo "See logs for details" >> $GITHUB_STEP_SUMMARY echo '```' >> $GITHUB_STEP_SUMMARY echo "" >> $GITHUB_STEP_SUMMARY echo "### Verified Behaviors:" >> $GITHUB_STEP_SUMMARY echo "- Requests within limit return HTTP 200" >> $GITHUB_STEP_SUMMARY echo "- Requests exceeding limit return HTTP 429" >> $GITHUB_STEP_SUMMARY echo "- Retry-After header present on blocked responses" >> $GITHUB_STEP_SUMMARY echo "- Rate limit window resets correctly" >> $GITHUB_STEP_SUMMARY else echo "❌ **Rate limit tests failed**" >> $GITHUB_STEP_SUMMARY echo "" >> $GITHUB_STEP_SUMMARY echo "### Failure Details:" >> $GITHUB_STEP_SUMMARY echo '```' >> $GITHUB_STEP_SUMMARY grep -E "✗|FAIL|Error|failed|expected" ratelimit-test-output.txt | head -30 >> $GITHUB_STEP_SUMMARY || echo "See logs for details" >> $GITHUB_STEP_SUMMARY echo '```' >> $GITHUB_STEP_SUMMARY fi - name: Cleanup if: always() run: | docker rm -f charon-ratelimit-test || true docker rm -f ratelimit-backend || true docker volume rm charon_ratelimit_data caddy_ratelimit_data caddy_ratelimit_config 2>/dev/null || true docker network rm containers_default || true