package handlers import ( "net/http" "net/http/httptest" "testing" "time" "github.com/gin-gonic/gin" "github.com/stretchr/testify/assert" "gorm.io/driver/sqlite" "gorm.io/gorm" "github.com/Wikid82/charon/backend/internal/models" "github.com/Wikid82/charon/backend/internal/services" ) func TestCertificateHandler_List_DBError(t *testing.T) { db, _ := gorm.Open(sqlite.Open(":memory:"), &gorm.Config{}) // Don't migrate to cause error gin.SetMode(gin.TestMode) r := gin.New() r.Use(mockAuthMiddleware()) svc := services.NewCertificateService("/tmp", db) h := NewCertificateHandler(svc, nil, nil) r.GET("/api/certificates", h.List) req := httptest.NewRequest(http.MethodGet, "/api/certificates", http.NoBody) w := httptest.NewRecorder() r.ServeHTTP(w, req) assert.Equal(t, http.StatusInternalServerError, w.Code) } func TestCertificateHandler_Delete_InvalidID(t *testing.T) { db, _ := gorm.Open(sqlite.Open(":memory:"), &gorm.Config{}) _ = db.AutoMigrate(&models.SSLCertificate{}, &models.ProxyHost{}) gin.SetMode(gin.TestMode) r := gin.New() r.Use(mockAuthMiddleware()) svc := services.NewCertificateService("/tmp", db) h := NewCertificateHandler(svc, nil, nil) r.DELETE("/api/certificates/:id", h.Delete) req := httptest.NewRequest(http.MethodDelete, "/api/certificates/invalid", http.NoBody) w := httptest.NewRecorder() r.ServeHTTP(w, req) assert.Equal(t, http.StatusBadRequest, w.Code) } func TestCertificateHandler_Delete_NotFound(t *testing.T) { // Use unique in-memory DB per test to avoid SQLite locking issues in parallel test runs db, _ := gorm.Open(sqlite.Open(":memory:"), &gorm.Config{}) _ = db.AutoMigrate(&models.SSLCertificate{}, &models.ProxyHost{}) gin.SetMode(gin.TestMode) r := gin.New() r.Use(mockAuthMiddleware()) svc := services.NewCertificateService("/tmp", db) h := NewCertificateHandler(svc, nil, nil) r.DELETE("/api/certificates/:id", h.Delete) req := httptest.NewRequest(http.MethodDelete, "/api/certificates/9999", http.NoBody) w := httptest.NewRecorder() r.ServeHTTP(w, req) assert.Equal(t, http.StatusInternalServerError, w.Code) } func TestCertificateHandler_Delete_NoBackupService(t *testing.T) { // Use unique in-memory DB per test to avoid SQLite locking issues in parallel test runs db, _ := gorm.Open(sqlite.Open(":memory:"), &gorm.Config{}) _ = db.AutoMigrate(&models.SSLCertificate{}, &models.ProxyHost{}) // Create certificate cert := models.SSLCertificate{UUID: "test-cert-no-backup", Name: "no-backup-cert", Provider: "custom", Domains: "nobackup.example.com"} db.Create(&cert) gin.SetMode(gin.TestMode) r := gin.New() r.Use(mockAuthMiddleware()) svc := services.NewCertificateService("/tmp", db) // Wait for background sync goroutine to complete to avoid race with -race flag // NewCertificateService spawns a goroutine that immediately queries the DB // which can race with our test HTTP request. Give it time to complete. // In real usage, this isn't an issue because the server starts before receiving requests. // Alternative would be to add a WaitGroup to CertificateService, but that's overkill for tests. // A simple sleep is acceptable here as it's test-only code. // 100ms is more than enough for the goroutine to finish its initial sync. // This is the minimum reliable wait time based on empirical testing with -race flag. // The goroutine needs to: acquire mutex, stat directory, query DB, release mutex. // On CI runners, this can take longer than on local dev machines. time.Sleep(200 * time.Millisecond) // No backup service h := NewCertificateHandler(svc, nil, nil) r.DELETE("/api/certificates/:id", h.Delete) req := httptest.NewRequest(http.MethodDelete, "/api/certificates/"+toStr(cert.ID), http.NoBody) w := httptest.NewRecorder() r.ServeHTTP(w, req) // Should still succeed without backup service assert.Equal(t, http.StatusOK, w.Code) } func TestCertificateHandler_Delete_CheckUsageDBError(t *testing.T) { // Use unique in-memory DB per test to avoid SQLite locking issues in parallel test runs db, _ := gorm.Open(sqlite.Open(":memory:"), &gorm.Config{}) // Only migrate SSLCertificate, not ProxyHost to cause error when checking usage _ = db.AutoMigrate(&models.SSLCertificate{}) // Create certificate cert := models.SSLCertificate{UUID: "test-cert-db-err", Name: "db-error-cert", Provider: "custom", Domains: "dberr.example.com"} db.Create(&cert) gin.SetMode(gin.TestMode) r := gin.New() r.Use(mockAuthMiddleware()) svc := services.NewCertificateService("/tmp", db) h := NewCertificateHandler(svc, nil, nil) r.DELETE("/api/certificates/:id", h.Delete) req := httptest.NewRequest(http.MethodDelete, "/api/certificates/"+toStr(cert.ID), http.NoBody) w := httptest.NewRecorder() r.ServeHTTP(w, req) assert.Equal(t, http.StatusInternalServerError, w.Code) } func TestCertificateHandler_List_WithCertificates(t *testing.T) { // Use unique in-memory DB per test to avoid SQLite locking issues in parallel test runs db, _ := gorm.Open(sqlite.Open(":memory:"), &gorm.Config{}) _ = db.AutoMigrate(&models.SSLCertificate{}, &models.ProxyHost{}) // Create certificates db.Create(&models.SSLCertificate{UUID: "cert-1", Name: "Cert 1", Provider: "custom", Domains: "one.example.com"}) db.Create(&models.SSLCertificate{UUID: "cert-2", Name: "Cert 2", Provider: "custom", Domains: "two.example.com"}) gin.SetMode(gin.TestMode) r := gin.New() r.Use(mockAuthMiddleware()) svc := services.NewCertificateService("/tmp", db) h := NewCertificateHandler(svc, nil, nil) r.GET("/api/certificates", h.List) req := httptest.NewRequest(http.MethodGet, "/api/certificates", http.NoBody) w := httptest.NewRecorder() r.ServeHTTP(w, req) assert.Equal(t, http.StatusOK, w.Code) assert.Contains(t, w.Body.String(), "Cert 1") assert.Contains(t, w.Body.String(), "Cert 2") } func TestCertificateHandler_Delete_ZeroID(t *testing.T) { // Tests the ID=0 validation check (line 149-152 in certificate_handler.go) // DELETE /api/certificates/0 should return 400 Bad Request db, _ := gorm.Open(sqlite.Open(":memory:"), &gorm.Config{}) _ = db.AutoMigrate(&models.SSLCertificate{}, &models.ProxyHost{}) gin.SetMode(gin.TestMode) r := gin.New() r.Use(mockAuthMiddleware()) svc := services.NewCertificateService("/tmp", db) h := NewCertificateHandler(svc, nil, nil) r.DELETE("/api/certificates/:id", h.Delete) req := httptest.NewRequest(http.MethodDelete, "/api/certificates/0", http.NoBody) w := httptest.NewRecorder() r.ServeHTTP(w, req) assert.Equal(t, http.StatusBadRequest, w.Code) assert.Contains(t, w.Body.String(), "invalid id") }