- Implemented tests for the emergency server (Tier 2) to validate health checks, security reset functionality, and independent access.
- Created a comprehensive suite for system settings feature toggles, ensuring proper state management and API call metrics reporting.
- Removed redundant feature toggle tests from the system settings spec to maintain clarity and focus.
- Enhanced test isolation by restoring default feature flag states after each test.
Update CI pipeline to pass the built Docker image to integration tests as a file artifact instead of pulling from a registry.
Adds explicit list of integration tests to build-image job outputs logic
Adds step to export charon:local image to tarball in linux/amd64 architecture
Updates integration jobs to download and load the image artifact
Resolves "invalid reference format" errors when registry tags are missing or invalid
Enables integration testing on PRs that do not push to registry
Removed log masking for image refs to enable debugging
Added whitespace trimming for digest output
Implemented 'docker manifest inspect' gate to fail fast on invalid refs
Switched to printf for safer output logging
Added explicit validation for IMAGE_NAME and DEFAULT_TAG to prevent empty values
Implemented per-tag validation loop to catch empty or malformed tags before build
Added debug step to echo generated tags immediately before build-push-action
Ensures invalid Docker references are caught early with descriptive errors
Rewrote the Emit image outputs step in the build-image job to robustly handle Docker image references.
Replaced fragile grep parsing with a safe while read loop for multiline tags.
Implemented deterministic prioritization: Digest > Matching Tag > First Tag.
Added explicit error handling to fail the build immediately if no valid reference is found, preventing "invalid reference format" errors in downstream integration jobs.
Changed 4 files
Detailed explanation of:
- What behavior changed: Removed the `integration_gate_ok` shell variable from the `pipeline-gate` job.
- Why the change was necessary: The variable was defined but not used, causing `shellcheck` (via `actionlint`) to fail the pre-commit hook.
- Any important side effects or considerations: None; the logic relying on this condition recalculates it inline using GitHub Actions expressions.
- Make container prune run perform deletions by default (workflow_dispatch default now false for dry_run)
- Enhance prune script to estimate candidate and deleted image sizes (Docker Hub best-effort; GHCR manifest fallback)
- Emit machine-readable summary (`prune-summary.env`) and human-readable summary to the workflow run
- Upload logs + summary as artifacts and expose `space_saved` in the run summary
Why:
- Previously the scheduled job used dry-run by default and only logged candidates; this change makes scheduled pruning effective and provides visibility into storage reclaimed.
Impact:
- Runs will now remove eligible images by default (use dry_run=true to test)
- Size calculations are best-effort and may be incomplete if registry APIs do not expose sizes
- Fixed "Emit image outputs" step to always populate image references
- Primary: uses digest from docker/build-push-action when available
- Fallback: extracts image tag from steps.tags when digest unavailable
- Ensures image_ref_dockerhub is never empty after successful build
- Added `if: always()` to all gate jobs (integration, coverage, codecov, pipeline)
- Gates now always execute to evaluate upstream job results
- Prevents cascading skips when jobs intentionally skip or fail
- Properly blocks downstream jobs only when gates actually fail
Pipeline now continues through all stages as designed, blocking only on real failures.
Fixes https://github.com/Wikid82/Charon/actions/runs/21803232380
Integration, E2E, and security jobs were being skipped on PR builds because
they required push_image == 'true'. Since the build succeeded and images were
available, these jobs should run regardless of push policy.
Changed conditions to depend on build success and image availability rather
than registry push status. This allows comprehensive testing on all builds
while still optimizing resource usage where needed.
- Remove `if: always()` from integration-gate, coverage-gate, codecov-gate, pipeline-gate
- Gates now naturally skip when their upstream dependencies are skipped (fork PR behavior)
- Prevents confusing "complete" status when nothing actually ran
- Fork PRs will show "skipped" in UI instead of obscuring behavior behind gate success
- Aligns with GitHub Actions standard job dependency semantics
- Fixed github.head_ref actionlint error by passing via environment variable
instead of direct shell interpolation in ci-pipeline.yml
- Aligned E2E coverage artifact handling to shard artifacts and updated
Codecov upload to use glob pattern for multi-shard merge
- Added workflow_run trigger to security-pr.yml for docker-build integration
while retaining workflow_dispatch for manual runs
- Added workflow_run trigger to supply-chain-pr.yml for docker-build integration
while retaining workflow_dispatch for manual runs
- All individual workflows now support both automatic (workflow_run) and manual
(workflow_dispatch) triggering, maintaining design intent
- Audited remaining workflows; no additional blockers found
- All actionlint and pre-commit validations now passing
- Full pipeline trigger chain now functional
- Updated environment variable assignments in multiple workflow files to use double quotes for consistency and to prevent potential issues with variable expansion.
- Refactored echo commands to group multiple lines into a single block for improved readability in the following workflows:
- release-goreleaser.yml
- renovate_prune.yml
- security-pr.yml
- security-weekly-rebuild.yml
- supply-chain-pr.yml
- supply-chain-verify.yml
- update-geolite2.yml
- waf-integration.yml
- weekly-nightly-promotion.yml
The golangci-lint-action v9.2.0 dropped support for golangci-lint v1.x
and requires v2.x versions. The error "golangci-lint v1 is not supported
by golangci-lint-action >= v7" indicates we need to upgrade, not downgrade.
Updated both ci-pipeline.yml and quality-checks.yml from v1.64.5 to v2.8.0
to align with the current golangci-lint major version.
Fixes: #666 (golangci-lint version compatibility error)
Previously, Phase 1 optimization restricted feature branch pushes to
linux/amd64 only for faster builds. This unintentionally prevented
arm64 images from being published to Docker Hub.
Changes:
- Feature branches now build for both linux/amd64 and linux/arm64
- PRs remain single-platform (amd64) for fast feedback
- Only PRs create artifacts (multi-platform manifests can't be loaded locally)
- Updated comments to reflect new platform behavior
Result: feature/beta-release will now publish both amd64 and arm64
images to Docker Hub on every push.
Closes: User report - arm64 missing from Docker Hub
The golangci-lint-action v9.2.0 requires version strings in "vX.Y.Z" format.
Previous attempt to remove the "v" prefix caused validation error:
"invalid version string '1.64.5', expected format v1.2 or v1.2.3"
Updated both ci-pipeline.yml and quality-checks.yml to use "v1.64.5"
instead of "1.64.5" to match the action's expected format.
Fixes: #666 (PR CI validation failure)
- CI now focuses only on Dockerfile validation and security scanning
- Go code linting is handled locally via pre-commit hooks and DoD checklist
- Prevents CI failures from missing golangci-lint configuration
- Aligns CI responsibilities with local development workflow
- Make lint steps fail the pipeline so issues block merges
- Skip Node cache setup when the frontend lockfile is missing
- Cancel older CI runs for the same ref to reduce queue delays
- Updated quality-checks.yml to support manual dispatch with frontend checks.
- Modified rate-limit-integration.yml to remove workflow_run triggers and adjust conditions for execution.
- Removed pull request triggers from repo-health.yml, retaining only scheduled and manual dispatch.
- Adjusted security-pr.yml and supply-chain-pr.yml to eliminate workflow_run dependencies and refine execution conditions.
- Cleaned up supply-chain-verify.yml by removing workflow_run triggers and ensuring proper execution conditions.
- Updated waf-integration.yml to remove workflow_run triggers, allowing manual dispatch only.
- Revised current_spec.md to reflect the consolidation of CI workflows into a single pipeline, detailing objectives, research findings, and implementation plans.
