From ca80149faafad52199ff3c8e12197410fa48001e Mon Sep 17 00:00:00 2001 From: Jeremy Date: Fri, 30 Jan 2026 15:07:32 +0000 Subject: [PATCH] fix(ci): skip Docker artifact steps for Renovate PRs The "Save Docker Image as Artifact" and "Upload Image Artifact" steps were running even when skip_build=true, causing CI failures on Renovate dependency update PRs. Add skip_build check to artifact saving step condition Add skip_build check to artifact upload step condition Aligns artifact steps with existing build skip logic --- .github/workflows/docker-build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/docker-build.yml b/.github/workflows/docker-build.yml index b9670e95..76f4e65e 100644 --- a/.github/workflows/docker-build.yml +++ b/.github/workflows/docker-build.yml @@ -180,7 +180,7 @@ jobs: # 2. Image doesn't exist locally after build # 3. Artifact creation fails - name: Save Docker Image as Artifact - if: github.event_name == 'pull_request' || steps.skip.outputs.is_feature_push == 'true' + if: success() && steps.skip.outputs.skip_build != 'true' && (github.event_name == 'pull_request' || steps.skip.outputs.is_feature_push == 'true') run: | # Extract the first tag from metadata action (PR tag) IMAGE_TAG=$(echo "${{ steps.meta.outputs.tags }}" | head -n 1) @@ -211,7 +211,7 @@ jobs: ls -lh /tmp/charon-pr-image.tar - name: Upload Image Artifact - if: github.event_name == 'pull_request' || steps.skip.outputs.is_feature_push == 'true' + if: success() && steps.skip.outputs.skip_build != 'true' && (github.event_name == 'pull_request' || steps.skip.outputs.is_feature_push == 'true') uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0 with: name: ${{ github.event_name == 'pull_request' && format('pr-image-{0}', github.event.pull_request.number) || 'push-image' }}