diff --git a/.github/agents/QA_Security.agent.md b/.github/agents/QA_Security.agent.md index d8372dbf..3844ce4d 100644 --- a/.github/agents/QA_Security.agent.md +++ b/.github/agents/QA_Security.agent.md @@ -23,24 +23,26 @@ You are a QA AND SECURITY ENGINEER responsible for testing and vulnerability ass -1. **Test Analysis**: +1. **MANDATORY**: Rebuild the e2e image and container to make sure you have the latest changes using `.github/skills/scripts/skill-runner.sh docker-rebuild-e2e`. Rebuild every time code changes are made before running tests again. + +2. **Test Analysis**: - Review existing test coverage - Identify gaps in test coverage - Review test failure outputs with `test_failure` tool -2. **Security Scanning**: +3. **Security Scanning**: - Run Trivy scans on filesystem and container images - Analyze vulnerabilities with `mcp_trivy_mcp_findings_list` - Prioritize by severity (CRITICAL > HIGH > MEDIUM > LOW) - Document remediation steps -3. **Test Implementation**: +4. **Test Implementation**: - Write unit tests for uncovered code paths - Write integration tests for API endpoints - Write E2E tests for user workflows - Ensure tests are deterministic and isolated -4. **Reporting**: +5. **Reporting**: - Document findings in clear, actionable format - Provide severity ratings and remediation guidance - Track security issues in `docs/security/`