From a263a5415a0c3d90ce3a0c0840b6cdc9dbfcf674 Mon Sep 17 00:00:00 2001
From: GitHub Actions <actions@github.com>
Date: Wed, 31 Dec 2025 21:44:40 +0000
Subject: [PATCH] fix: update type assertions in tests for improved type safety

---
 frontend/src/pages/CrowdSecConfig.tsx         |  3 ++-
 .../pages/__tests__/CrowdSecConfig.spec.tsx   | 14 ++++++-------
 .../pages/__tests__/SecurityHeaders.test.tsx  | 20 +++++++++----------
 3 files changed, 19 insertions(+), 18 deletions(-)

diff --git a/frontend/src/pages/CrowdSecConfig.tsx b/frontend/src/pages/CrowdSecConfig.tsx
index 9cd3d99a..0e9b8812 100644
--- a/frontend/src/pages/CrowdSecConfig.tsx
+++ b/frontend/src/pages/CrowdSecConfig.tsx
@@ -223,6 +223,7 @@ export default function CrowdSecConfig() {
     })
     setPresetPreview(selectedPreset.content || '')
     pullPresetMutation.mutate(selectedPreset.slug)
+    // eslint-disable-next-line react-hooks/exhaustive-deps -- Only re-run when slug changes, not on mutation/preset object identity changes
   }, [selectedPreset?.slug])
 
   const loadCachedPreview = async () => {
@@ -932,7 +933,7 @@ export default function CrowdSecConfig() {
             </div>
             <select
               value={sortBy}
-              onChange={(e) => setSortBy(e.target.value as any)}
+              onChange={(e) => setSortBy(e.target.value as 'alpha' | 'type' | 'source')}
               className="bg-gray-900 border border-gray-700 rounded-lg px-3 py-2 text-white"
             >
               <option value="alpha">{t('crowdsecConfig.presets.sortAlpha')}</option>
diff --git a/frontend/src/pages/__tests__/CrowdSecConfig.spec.tsx b/frontend/src/pages/__tests__/CrowdSecConfig.spec.tsx
index 554e5cc7..e4def031 100644
--- a/frontend/src/pages/__tests__/CrowdSecConfig.spec.tsx
+++ b/frontend/src/pages/__tests__/CrowdSecConfig.spec.tsx
@@ -1,5 +1,5 @@
 import { describe, it, expect, vi, beforeEach } from 'vitest'
-import { AxiosError } from 'axios'
+import { AxiosError, AxiosResponse } from 'axios'
 import { render, screen, waitFor } from '@testing-library/react'
 import userEvent from '@testing-library/user-event'
 import { QueryClient, QueryClientProvider } from '@tanstack/react-query'
@@ -261,9 +261,9 @@ describe('CrowdSecConfig', () => {
       status: 501,
       statusText: 'Not Implemented',
       headers: {},
-      config: {},
+      config: { headers: {} },
       data: {},
-    } as any)
+    } as AxiosResponse)
     vi.mocked(presetsApi.applyCrowdsecPreset).mockRejectedValue(axiosError)
 
     renderWithProviders(<CrowdSecConfig />)
@@ -287,9 +287,9 @@ describe('CrowdSecConfig', () => {
       status: 400,
       statusText: 'Bad Request',
       headers: {},
-      config: {},
+      config: { headers: {} },
       data: { error: 'slug invalid' },
-    } as any)
+    } as AxiosResponse)
     vi.mocked(presetsApi.pullCrowdsecPreset).mockRejectedValueOnce(validationError)
 
     renderWithProviders(<CrowdSecConfig />)
@@ -320,9 +320,9 @@ describe('CrowdSecConfig', () => {
       status: 503,
       statusText: 'Service Unavailable',
       headers: {},
-      config: {},
+      config: { headers: {} },
       data: { error: 'hub service unavailable' },
-    } as any)
+    } as AxiosResponse)
     vi.mocked(presetsApi.pullCrowdsecPreset).mockRejectedValue(hubError)
     vi.mocked(presetsApi.getCrowdsecPresetCache).mockResolvedValue({ preview: 'cached-preview', cache_key: 'cache-hub', etag: 'etag-hub' })
 
diff --git a/frontend/src/pages/__tests__/SecurityHeaders.test.tsx b/frontend/src/pages/__tests__/SecurityHeaders.test.tsx
index 0469368f..9350f189 100644
--- a/frontend/src/pages/__tests__/SecurityHeaders.test.tsx
+++ b/frontend/src/pages/__tests__/SecurityHeaders.test.tsx
@@ -3,7 +3,7 @@ import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
 import { MemoryRouter } from 'react-router-dom';
 import { describe, it, expect, vi } from 'vitest';
 import SecurityHeaders from '../../pages/SecurityHeaders';
-import { securityHeadersApi } from '../../api/securityHeaders';
+import { securityHeadersApi, SecurityHeaderProfile } from '../../api/securityHeaders';
 import { createBackup } from '../../api/backups';
 
 vi.mock('../../api/securityHeaders');
@@ -68,7 +68,7 @@ describe('SecurityHeaders', () => {
       },
     ];
 
-    vi.mocked(securityHeadersApi.listProfiles).mockResolvedValue(mockProfiles as any);
+    vi.mocked(securityHeadersApi.listProfiles).mockResolvedValue(mockProfiles as SecurityHeaderProfile[]);
     vi.mocked(securityHeadersApi.getPresets).mockResolvedValue([]);
 
     render(<SecurityHeaders />, { wrapper: createWrapper() });
@@ -101,7 +101,7 @@ describe('SecurityHeaders', () => {
       },
     ];
 
-    vi.mocked(securityHeadersApi.listProfiles).mockResolvedValue(mockProfiles as any);
+    vi.mocked(securityHeadersApi.listProfiles).mockResolvedValue(mockProfiles as SecurityHeaderProfile[]);
     vi.mocked(securityHeadersApi.getPresets).mockResolvedValue([]);
 
     render(<SecurityHeaders />, { wrapper: createWrapper() });
@@ -141,7 +141,7 @@ describe('SecurityHeaders', () => {
       },
     ];
 
-    vi.mocked(securityHeadersApi.listProfiles).mockResolvedValue(mockProfiles as any);
+    vi.mocked(securityHeadersApi.listProfiles).mockResolvedValue(mockProfiles as SecurityHeaderProfile[]);
     vi.mocked(securityHeadersApi.getPresets).mockResolvedValue([]);
     vi.mocked(securityHeadersApi.calculateScore).mockResolvedValue({
       score: 85,
@@ -177,13 +177,13 @@ describe('SecurityHeaders', () => {
       },
     ];
 
-    vi.mocked(securityHeadersApi.listProfiles).mockResolvedValue(mockProfiles as any);
+    vi.mocked(securityHeadersApi.listProfiles).mockResolvedValue(mockProfiles as SecurityHeaderProfile[]);
     vi.mocked(securityHeadersApi.getPresets).mockResolvedValue([]);
     vi.mocked(securityHeadersApi.createProfile).mockResolvedValue({
       id: 2,
       name: 'Original Profile (Copy)',
       security_score: 85,
-    } as any);
+    } as SecurityHeaderProfile);
 
     render(<SecurityHeaders />, { wrapper: createWrapper() });
 
@@ -216,9 +216,9 @@ describe('SecurityHeaders', () => {
       },
     ];
 
-    vi.mocked(securityHeadersApi.listProfiles).mockResolvedValue(mockProfiles as any);
+    vi.mocked(securityHeadersApi.listProfiles).mockResolvedValue(mockProfiles as SecurityHeaderProfile[]);
     vi.mocked(securityHeadersApi.getPresets).mockResolvedValue([]);
-    vi.mocked(createBackup).mockResolvedValue({ id: 1 } as any);
+    vi.mocked(createBackup).mockResolvedValue({ filename: 'backup.tar.gz' });
     vi.mocked(securityHeadersApi.deleteProfile).mockResolvedValue(undefined);
 
     render(<SecurityHeaders />, { wrapper: createWrapper() });
@@ -268,7 +268,7 @@ describe('SecurityHeaders', () => {
       },
     ];
 
-    vi.mocked(securityHeadersApi.listProfiles).mockResolvedValue(mockProfiles as any);
+    vi.mocked(securityHeadersApi.listProfiles).mockResolvedValue(mockProfiles as SecurityHeaderProfile[]);
     vi.mocked(securityHeadersApi.getPresets).mockResolvedValue([]);
 
     render(<SecurityHeaders />, { wrapper: createWrapper() });
@@ -298,7 +298,7 @@ describe('SecurityHeaders', () => {
       },
     ];
 
-    vi.mocked(securityHeadersApi.listProfiles).mockResolvedValue(mockProfiles as any);
+    vi.mocked(securityHeadersApi.listProfiles).mockResolvedValue(mockProfiles as SecurityHeaderProfile[]);
     vi.mocked(securityHeadersApi.getPresets).mockResolvedValue([]);
 
     render(<SecurityHeaders />, { wrapper: createWrapper() });