diff --git a/.github/agents/Managment.agent.md b/.github/agents/Managment.agent.md index f6afce10..599633af 100644 --- a/.github/agents/Managment.agent.md +++ b/.github/agents/Managment.agent.md @@ -86,6 +86,7 @@ The task is not complete until ALL of the following pass with zero issues: 1. **Playwright E2E Tests (MANDATORY - Run First)**: - **Run**: `npx playwright test --project=chromium` from project root + - **No Truncation**: Never pipe output through `head`, `tail`, or other truncating commands. Playwright requires user input to quit when piped, causing hangs. - **Why First**: If the app is broken at E2E level, unit tests may need updates. Catch integration issues early. - **Scope**: Run tests relevant to modified features (e.g., `tests/manual-dns-provider.spec.ts`) - **On Failure**: Trace root cause through frontend → backend flow before proceeding diff --git a/.github/agents/QA_Security.agent.md b/.github/agents/QA_Security.agent.md index 1f788e48..f72dd0e5 100644 --- a/.github/agents/QA_Security.agent.md +++ b/.github/agents/QA_Security.agent.md @@ -111,7 +111,7 @@ The task is not complete until ALL of the following pass with zero issues: -- **NO** Truncating of coverage tests runs. These require user interaction and hang if ran with Tail or Head. Use the provided skills to run the full coverage script. +- **NO** Truncating of test runs with `head` or `tail`. Coverage tests AND Playwright E2E tests require user interaction and hang indefinitely if piped through truncating commands. Use the provided skills to run tests directly without output truncation. - **TERSE OUTPUT**: Do not explain the code. Output ONLY the code blocks or command results. - **NO CONVERSATION**: If the task is done, output "DONE". - **NO HALLUCINATIONS**: Do not guess file paths. Verify them with `list_dir`. diff --git a/.github/agents/playwright-tester.agent.md b/.github/agents/playwright-tester.agent.md index 809af0e3..a27d76d1 100644 --- a/.github/agents/playwright-tester.agent.md +++ b/.github/agents/playwright-tester.agent.md @@ -12,3 +12,8 @@ model: Claude Sonnet 4 3. **Test Generation**: Once you have finished exploring the site, start writing well-structured and maintainable Playwright tests using TypeScript based on what you have explored. 4. **Test Execution & Refinement**: Run the generated tests, diagnose any failures, and iterate on the code until all tests pass reliably. 5. **Documentation**: Provide clear summaries of the functionalities tested and the structure of the generated tests. + +## Execution Constraints + +- **No Truncation**: Never pipe Playwright test output through `head`, `tail`, or other truncating commands. Playwright runs interactively and requires user input to quit when piped, causing the command to hang indefinitely. +- **Full Output**: Always capture the complete test output to analyze failures accurately. diff --git a/.github/instructions/playwright-typescript.instructions.md b/.github/instructions/playwright-typescript.instructions.md index ccb01b5b..c59d7169 100644 --- a/.github/instructions/playwright-typescript.instructions.md +++ b/.github/instructions/playwright-typescript.instructions.md @@ -76,6 +76,11 @@ test.describe('Movie Search Feature', () => { 4. **Validate**: Ensure tests pass consistently and cover the intended functionality 5. **Report**: Provide feedback on test results and any issues discovered +### Execution Constraints + +- **No Truncation**: Never pipe Playwright test output through `head`, `tail`, or other truncating commands. Playwright runs interactively and requires user input to quit when piped, causing the command to hang indefinitely. +- **Full Output**: Always capture the complete test output to analyze failures accurately. + ## Quality Checklist Before finalizing tests, ensure: diff --git a/.github/instructions/testing.instructions.md b/.github/instructions/testing.instructions.md index 025bcf0a..b779e930 100644 --- a/.github/instructions/testing.instructions.md +++ b/.github/instructions/testing.instructions.md @@ -9,6 +9,7 @@ description: 'Strict protocols for test execution, debugging, and coverage valid **MANDATORY**: Before running unit tests, verify the application functions correctly end-to-end. * **Run Playwright E2E Tests**: Execute `npx playwright test --project=chromium` from the project root. +* **No Truncation**: Never pipe Playwright test output through `head`, `tail`, or other truncating commands. Playwright tests run interactively and require user input to quit when piped, causing the command to hang indefinitely. * **Why First**: If the application is broken at the E2E level, unit tests may need updates. Playwright catches integration issues early. * **Base URL**: Tests use `PLAYWRIGHT_BASE_URL` env var or default from `playwright.config.js` (Tailscale IP: `http://100.98.12.109:8080`). * **On Failure**: Analyze failures, trace root cause through frontend → backend flow, then fix before proceeding to unit tests.