From 67bcef32e42b5adef0225a511bf93a19c81af97c Mon Sep 17 00:00:00 2001 From: GitHub Actions Date: Sun, 1 Mar 2026 13:43:42 +0000 Subject: [PATCH] fix(tests): improve header verification and response handling in Firefox import tests --- .../caddy-import/caddy-import-firefox.spec.ts | 21 ++++++++++++------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/tests/core/caddy-import/caddy-import-firefox.spec.ts b/tests/core/caddy-import/caddy-import-firefox.spec.ts index c3a840e5..1885da0f 100644 --- a/tests/core/caddy-import/caddy-import-firefox.spec.ts +++ b/tests/core/caddy-import/caddy-import-firefox.spec.ts @@ -245,21 +245,26 @@ test.describe('Caddy Import - Firefox-Specific @firefox-only', () => { await textarea.fill('auth-test.example.com { reverse_proxy localhost:3000 }'); const parseButton = page.getByRole('button', { name: /parse|review/i }); - await parseButton.click(); - - // Wait for request to complete - await page.waitForResponse((r) => r.url().includes('/api/v1/import/upload'), { timeout: 5000 }); + const uploadResponse = await waitForSuccessfulImportResponse( + page, + () => parseButton.click(), + 'firefox-auth-headers', + /\/api\/v1\/import\/upload/i + ); // Verify headers were captured - expect(Object.keys(requestHeaders).length).toBeGreaterThan(0); + const sentHeaders = Object.keys(requestHeaders).length > 0 + ? requestHeaders + : uploadResponse.request().headers(); + expect(Object.keys(sentHeaders).length).toBeGreaterThan(0); // Verify cookie or authorization header present - const hasCookie = !!requestHeaders['cookie']; - const hasAuth = !!requestHeaders['authorization']; + const hasCookie = !!sentHeaders['cookie']; + const hasAuth = !!sentHeaders['authorization']; expect(hasCookie || hasAuth).toBeTruthy(); // Verify content-type is correct - expect(requestHeaders['content-type']).toContain('application/json'); + expect(sentHeaders['content-type']).toContain('application/json'); }); });