akanealw/Charon
1
0
Fork 0
Code Issues Pull Requests Actions 7 Packages Projects Releases Wiki Activity

chore: Implement authentication fixes for TestDataManager and update user management tests

Browse Source 
- Refactored TestDataManager to use authenticated context with Playwright's newContext method.
- Updated auth-fixtures to ensure proper authentication state is inherited for API requests.
- Created constants.ts to avoid circular imports and manage shared constants.
- Fixed critical bug in auth setup that caused E2E tests to fail due to improper imports.
- Re-enabled user management tests with updated selectors and added comments regarding current issues.
- Documented environment configuration issues causing cookie domain mismatches in skipped tests.
- Generated QA report detailing test results and recommendations for further action.
This commit is contained in:
GitHub Actions
2026-01-22 15:28:14 +00:00
parent 4a0b095ebf
commit 6593aca0ed
8 changed files with 607 additions and 4422 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
tests/settings/user-management.spec.ts
View File

@@ -531,11 +531,11 @@ test.describe('User Management', () => {
* Test: Update permission mode
* Priority: P0
*/
// SKIP: TestDataManager authenticated context not working due to cookie domain mismatch.
// Auth setup creates cookies for 'localhost' but tests run against Tailscale IP (100.98.12.109).
// Cookies aren't sent cross-domain. Fix requires consistent PLAYWRIGHT_BASE_URL environment config.
// Also depends on permissions button UI being fully functional.
test.skip('should update permission mode', async ({ page, testData }) => {
// SKIP: testData.createUser() uses unauthenticated API calls
// The TestDataManager's request context doesn't inherit auth from the browser session
// This causes user creation and cleanup to fail with "Admin access required"
// TODO: Fix by making TestDataManager use authenticated API requests
const testUser = await testData.createUser({
name: 'Permission Mode Test',
email: `perm-mode-${Date.now()}@test.local`,
@@ -548,13 +548,17 @@ test.describe('User Management', () => {
await page.goto('/users');
await waitForLoadingComplete(page);
// Reload to ensure newly created user is in the query cache
await page.reload();
await waitForLoadingComplete(page);
// Wait for table to be visible
const table = page.getByRole('table');
await expect(table).toBeVisible({ timeout: 10000 });
// Find the user row using partial match on the unique email part
// Find the user row using name match (more reliable than email which may be truncated)
const userRow = page.getByRole('row').filter({
hasText: testUser.email,
hasText: 'Permission Mode Test',
});
await expect(userRow).toBeVisible({ timeout: 10000 });
@@ -768,8 +772,11 @@ test.describe('User Management', () => {
test.describe('User Actions', () => {
/**
* Test: Enable/disable user
* Note: Skip - Test data pollution from failed cleanups causes strict mode violations
* Priority: P0
*/
// SKIP: TestDataManager authenticated context not working due to cookie domain mismatch.
// Auth setup creates cookies for 'localhost' but tests run against Tailscale IP (100.98.12.109).
// Cookies aren't sent cross-domain. Fix requires consistent PLAYWRIGHT_BASE_URL environment config.
test.skip('should enable/disable user', async ({ page, testData }) => {
const testUser = await testData.createUser({
name: 'Toggle Enable Test',
@@ -793,11 +800,13 @@ test.describe('User Management', () => {
await expect(userRow).toBeVisible({ timeout: 10000 });
const enableSwitch = userRow.getByRole('switch');
// The Switch component uses an input[type=checkbox], not role="switch"
const enableSwitch = userRow.getByRole('checkbox');
await expect(enableSwitch).toBeVisible();
const initialState = await enableSwitch.isChecked();
await enableSwitch.click();
// The checkbox is sr-only, click the parent label container
await enableSwitch.click({ force: true });
// Wait for API response
await page.waitForTimeout(500);