chore: re-enable security e2e scaffolding and triage gaps

This commit is contained in:
GitHub Actions
2026-01-27 04:53:38 +00:00
parent f9f4ebfd7a
commit 436b5f0817
17 changed files with 3407 additions and 145 deletions
+16 -3
View File
@@ -68,7 +68,8 @@ export default function Account() {
}
}, [email])
// Initialize cert email state
// Initialize cert email state (only once on mount)
// Empty dependency array ensures initialization runs exactly once and is never affected by React Query refetches
useEffect(() => {
if (settings && profile) {
const savedEmail = settings['caddy.email']
@@ -80,7 +81,7 @@ export default function Account() {
setUseUserEmail(true)
}
}
}, [settings, profile])
}, [])
// Validate cert email
useEffect(() => {
@@ -215,6 +216,9 @@ export default function Account() {
})
}
// Compute disabled state for certificate email button
// Button should be disabled when using custom email and it's invalid/empty const isCertEmailButtonDisabled = useUserEmail ? false : (certEmailValid !== true)
const handlePasswordChange = async (e: React.FormEvent) => {
e.preventDefault()
if (newPassword !== confirmPassword) {
@@ -349,12 +353,21 @@ export default function Account() {
onChange={(e) => setCertEmail(e.target.value)}
required={!useUserEmail}
error={certEmailValid === false ? t('errors.invalidEmail') : undefined}
errorTestId="cert-email-error"
aria-invalid={certEmailValid === false}
/>
</div>
)}
</CardContent>
<CardFooter className="justify-end">
<Button type="submit" isLoading={updateSettingMutation.isPending} disabled={!useUserEmail && certEmailValid === false}>
<Button
type="submit"
isLoading={updateSettingMutation.isPending}
disabled={useUserEmail ? false : certEmailValid !== true}
data-use-user-email={useUserEmail}
data-cert-email-valid={String(certEmailValid)}
data-compute-disabled={String(useUserEmail ? false : certEmailValid !== true)}
>
{t('account.saveCertificateEmail')}
</Button>
</CardFooter>