From 355992e665d26c12d28156a9c7bca429886739b7 Mon Sep 17 00:00:00 2001 From: GitHub Actions Date: Tue, 2 Dec 2025 22:08:51 +0000 Subject: [PATCH] refactor: update verification and testing commands for clarity and consistency --- .github/agents/Frontend_Dev.agent.md | 10 ++++++---- frontend/package.json | 3 ++- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/.github/agents/Frontend_Dev.agent.md b/.github/agents/Frontend_Dev.agent.md index 8a06087c..bd269d30 100644 --- a/.github/agents/Frontend_Dev.agent.md +++ b/.github/agents/Frontend_Dev.agent.md @@ -35,10 +35,12 @@ You do not just "make it work"; you make it **feel** professional, responsive, a - Verify tests pass with `npm run test`. 3. **Verification (Definition of Done)**: - - Run `npm run lint` and fix warnings and errors (so they don't become warnings). - - Run `npm run test` (Ensure no regressions). - - Run `npm run type-check` - - **MANDATORY**: Run `/projects/Charon/scripts/frontend-test-coverage.sh` as well as and fix any issues immediately and make sure coverage goals are met or exceeded. + - Run `npm run lint` and fix all errors. + - Run `npm run type-check`. + - **Test Execution**: Run `npm run test:ci`. + - *Note*: This runs tests in non-interactive mode. If tests fail, analyze the output and fix them. + - **Coverage**: Run `npm run check-coverage`. + - Ensure the script executes successfully and coverage goals are met. diff --git a/frontend/package.json b/frontend/package.json index df0e5e93..73972c3d 100644 --- a/frontend/package.json +++ b/frontend/package.json @@ -9,8 +9,9 @@ "type-check": "tsc --noEmit", "lint": "eslint . --report-unused-disable-directives", "preview": "vite preview", - "test": "vitest", + "test:ci": "vitest run", "test:ui": "vitest --ui", + "check-coverage": "bash ../scripts/frontend-test-coverage.sh", "pretest:coverage": "npm ci --silent && node -e \"require('fs').mkdirSync('coverage/.tmp', { recursive: true })\"", "test:coverage": "vitest --coverage --coverage.provider=istanbul --coverage.reporter=json-summary --coverage.reporter=lcov --coverage.reporter=text", "e2e:install": "npx playwright install --with-deps",