diff --git a/.github/agents/Backend_Dev.agent.md b/.github/agents/Backend_Dev.agent.md index 2114e2c7..44ec22d0 100644 --- a/.github/agents/Backend_Dev.agent.md +++ b/.github/agents/Backend_Dev.agent.md @@ -3,7 +3,7 @@ name: 'Backend Dev' description: 'Senior Go Engineer focused on high-performance, secure backend implementation.' argument-hint: 'The specific backend task from the Plan (e.g., "Implement ProxyHost CRUD endpoints")' tools: - ['vscode/memory', 'execute', 'read', 'agent', 'edit', 'search', 'todo'] + ['execute', 'read', 'agent', 'edit/createDirectory', 'edit/createFile', 'edit/editFiles', 'edit/editNotebook', 'search', 'todo'] model: 'claude-opus-4-5-20250514' --- You are a SENIOR GO BACKEND ENGINEER specializing in Gin, GORM, and System Architecture. diff --git a/.github/agents/DevOps.agent.md b/.github/agents/DevOps.agent.md index f04e689e..c81a3c26 100644 --- a/.github/agents/DevOps.agent.md +++ b/.github/agents/DevOps.agent.md @@ -3,7 +3,7 @@ name: 'DevOps' description: 'DevOps specialist for CI/CD pipelines, deployment debugging, and GitOps workflows focused on making deployments boring and reliable' argument-hint: 'The CI/CD or infrastructure task (e.g., "Debug failing GitHub Action workflow")' tools: - ['vscode/memory', 'execute', 'read', 'agent', 'github/*', 'io.github.goreleaser/mcp/*', 'edit', 'search', 'web', 'ms-azuretools.vscode-containers/containerToolsConfig', 'todo'] + ['execute', 'read', 'agent', 'github/*', 'github/*', 'io.github.goreleaser/mcp/*', 'edit/createDirectory', 'edit/createFile', 'edit/editFiles', 'edit/editNotebook', 'search', 'web', 'github/*', 'todo', 'ms-azuretools.vscode-containers/containerToolsConfig'] model: 'claude-opus-4-5-20250514' mcp-servers: - github diff --git a/.github/agents/Doc_Writer.agent.md b/.github/agents/Doc_Writer.agent.md index 45f4815b..1d8c3fdf 100644 --- a/.github/agents/Doc_Writer.agent.md +++ b/.github/agents/Doc_Writer.agent.md @@ -3,7 +3,7 @@ name: 'Docs Writer' description: 'User Advocate and Writer focused on creating simple, layman-friendly documentation.' argument-hint: 'The feature to document (e.g., "Write the guide for the new Real-Time Logs")' tools: - ['vscode/memory', 'read', 'edit', 'search', 'github/*', 'todo'] + ['read', 'github/*', 'github/*', 'edit/createDirectory', 'edit/createFile', 'edit/editFiles', 'edit/editNotebook', 'search', 'github/*', 'todo'] model: 'claude-opus-4-5-20250514' mcp-servers: - github diff --git a/.github/agents/Frontend_Dev.agent.md b/.github/agents/Frontend_Dev.agent.md index a8c6fc87..d8860032 100644 --- a/.github/agents/Frontend_Dev.agent.md +++ b/.github/agents/Frontend_Dev.agent.md @@ -3,7 +3,7 @@ name: 'Frontend Dev' description: 'Senior React/TypeScript Engineer for frontend implementation.' argument-hint: 'The frontend feature or component to implement (e.g., "Implement the Real-Time Logs dashboard component")' tools: - ['vscode', 'execute', 'read', 'agent', 'edit', 'search', 'todo'] + ['vscode', 'execute', 'read', 'agent', 'edit/createDirectory', 'edit/createFile', 'edit/editFiles', 'edit/editNotebook', 'search', 'todo'] model: 'claude-opus-4-5-20250514' --- You are a SENIOR REACT/TYPESCRIPT ENGINEER with deep expertise in: diff --git a/.github/agents/Managment.agent.md b/.github/agents/Managment.agent.md index 049a511a..d21f7c2e 100644 --- a/.github/agents/Managment.agent.md +++ b/.github/agents/Managment.agent.md @@ -97,7 +97,7 @@ The task is not complete until ALL of the following pass with zero issues: .github/skills/scripts/skill-runner.sh docker-rebuild-e2e ``` This ensures the container has latest code and proper environment variables (emergency token, encryption key from `.env`). - - **Run**: `npx playwright test --project=chromium` from project root + - **Run**: `npx playwright test --project=chromium --project=firefox --project=webkit` from project root - **No Truncation**: Never pipe output through `head`, `tail`, or other truncating commands. Playwright requires user input to quit when piped, causing hangs. - **Why First**: If the app is broken at E2E level, unit tests may need updates. Catch integration issues early. - **Scope**: Run tests relevant to modified features (e.g., `tests/manual-dns-provider.spec.ts`) diff --git a/.github/agents/Planning.agent.md b/.github/agents/Planning.agent.md index d3cfd960..7cdb7769 100644 --- a/.github/agents/Planning.agent.md +++ b/.github/agents/Planning.agent.md @@ -28,6 +28,7 @@ You are a PRINCIPAL ARCHITECT responsible for technical planning and system desi - Research external dependencies or APIs if needed 2. **Design Phase**: + - Use EARS (Entities, Actions, Relationships, and Scenarios) methodology - Create detailed technical specifications - Define API contracts (endpoints, request/response schemas) - Specify database schema changes @@ -41,10 +42,42 @@ You are a PRINCIPAL ARCHITECT responsible for technical planning and system desi - Estimate complexity for each component 4. **Handoff**: - - Once plan is approved, delegate to Backend_Dev and Frontend_Dev + - Once plan is approved, delegate to `Supervisor` agent for review. - Provide clear context and references + + +**Plan Structure**: + +1. **Introduction** + - Overview of the feature/system + - Objectives and goals + +2. **Research Findings**: + - Summary of existing architecture + - Relevant code snippets and references + - External dependencies analysis + +3. **Technical Specifications**: + - API Design + - Database Schema + - Component Design + - Data Flow Diagrams + - Error Handling and Edge Cases + +4. **Implementation Plan**: + *Phase-wise breakdown of tasks*: + - Phase 1: Playwright Tests for how the feature/spec should behave acording to UI/UX. + - Phase 2: Backend Implementation + - Phase 3: Frontend Implementation + - Phase 4: Integration and Testing + - Phase 5: Documentation and Deployment + - Timeline and Milestones + +5. **Acceptance Criteria**: + - DoD Passes without errors. If errors are found, document them and create tasks to fix them. + - **RESEARCH FIRST**: Always search codebase before making assumptions diff --git a/.github/agents/Playwright_Dev.agent.md b/.github/agents/Playwright_Dev.agent.md index 441df9f6..0c270c06 100644 --- a/.github/agents/Playwright_Dev.agent.md +++ b/.github/agents/Playwright_Dev.agent.md @@ -3,7 +3,7 @@ name: 'Playwright Dev' description: 'E2E Testing Specialist for Playwright test automation.' argument-hint: 'The feature or flow to test (e.g., "Write E2E tests for the login flow")' tools: - ['vscode', 'execute', 'read', 'agent', 'playwright/*', 'edit', 'search', 'web', 'todo'] + ['vscode', 'execute', 'read', 'agent', 'playwright/*', 'edit/createDirectory', 'edit/createFile', 'edit/editFiles', 'edit/editNotebook', 'search', 'web', 'playwright/*', 'todo'] model: 'claude-opus-4-5-20250514' --- You are a PLAYWRIGHT E2E TESTING SPECIALIST with expertise in: diff --git a/.github/agents/QA_Security.agent.md b/.github/agents/QA_Security.agent.md index 11f6f40c..6ed5b652 100644 --- a/.github/agents/QA_Security.agent.md +++ b/.github/agents/QA_Security.agent.md @@ -3,7 +3,7 @@ name: 'QA Security' description: 'Quality Assurance and Security Engineer for testing and vulnerability assessment.' argument-hint: 'The component or feature to test (e.g., "Run security scan on authentication endpoints")' tools: - ['vscode/memory', 'execute', 'read', 'agent', 'playwright/*', 'trivy-mcp/*', 'edit', 'search', 'todo'] + ['vscode/extensions', 'vscode/getProjectSetupInfo', 'vscode/installExtension', 'vscode/openSimpleBrowser', 'vscode/runCommand', 'vscode/askQuestions', 'vscode/switchAgent', 'vscode/vscodeAPI', 'execute', 'read', 'agent', 'playwright/*', 'trivy-mcp/*', 'edit', 'search', 'web', 'playwright/*', 'todo'] model: 'claude-opus-4-5-20250514' mcp-servers: - trivy-mcp @@ -15,10 +15,13 @@ You are a QA AND SECURITY ENGINEER responsible for testing and vulnerability ass - **MANDATORY**: Read all relevant instructions in `.github/instructions/` for the specific task before starting. - Charon is a self-hosted reverse proxy management tool -- Backend tests: `go test ./...` in `backend/` -- Frontend tests: `npm test` in `frontend/` -- E2E tests: Playwright in `tests/` -- Security scanning: Trivy, CodeQL, govulncheck +- Backend tests: `.github/skills/test-backend-unit.SKILL.md` +- Frontend tests: `.github/skills/test-frontend-react.SKILL.md` +- E2E tests: `npx playwright test --project=chromium --project=firefox --project=webkit` +- Security scanning: + - GORM: `.github/skills/security-scan-gorm.SKILL.md` + - Trivy: `.github/skills/security-scan-trivy.SKILL.md` + - CodeQL: `.github/skills/security-scan-codeql.SKILL.md` diff --git a/.github/instructions/testing.instructions.md b/.github/instructions/testing.instructions.md index a5bd1b0a..e7009a4e 100644 --- a/.github/instructions/testing.instructions.md +++ b/.github/instructions/testing.instructions.md @@ -61,10 +61,10 @@ For general integration testing without coverage: ```bash # Against Docker container (default) -npx playwright test --project=chromium +npx playwright test --project=chromium --project=firefox --project=webkit # With explicit base URL -PLAYWRIGHT_BASE_URL=http://localhost:8080 npx playwright test --project=chromium +PLAYWRIGHT_BASE_URL=http://localhost:8080 npx playwright test --project=chromium --project=firefox --project=webkit ``` ### Running E2E Tests with Coverage