diff --git a/.github/workflows/docker-build.yml b/.github/workflows/docker-build.yml index 28619ed1..5f2e432d 100644 --- a/.github/workflows/docker-build.yml +++ b/.github/workflows/docker-build.yml @@ -853,7 +853,7 @@ jobs: -p 8080:8080 \ -e CHARON_ENV=development \ -e CHARON_DEBUG=1 \ - -e CHARON_ENCRYPTION_KEY=test-key-for-ci-only-not-production \ + -e CHARON_ENCRYPTION_KEY=dGVzdC1lbmNyeXB0aW9uLWtleS1mb3ItY2ktMzJieXQ= \ "${IMAGE_REF}" - name: Wait for application health diff --git a/docs/plans/task.md b/docs/plans/task.md index 538d5405..96b4813c 100644 --- a/docs/plans/task.md +++ b/docs/plans/task.md @@ -1,75 +1,1200 @@ -## 1) Patch Coverage Issue - ✅ RESOLVED +Run npx playwright test --project=chromium -**Status**: Fixed via defensive code removal -**Approach**: Option 2 - Remove unreachable defensive code -**Commit**: Pending +Running 55 tests using 1 worker +Running initial setup to create test admin user... +Initial setup completed successfully +Logging in as test user... +Login successful +Auth state saved to /home/runner/work/Charon/Charon/playwright/.auth/user.json +·API Response: 404 {"error":"not found"} +×API Response: 404 {"error":"not found"} +×API Response: 404 {"error":"not found"} +FType select found: true +Number of options: 1 + Option 0: Loading... +Webhook option not found +°··Add button count: 2 +Page URL: http://localhost:8080/dns/providers +···°°°××F·××F····××F××F××F××F××F××F··××F···××F························ -### Summary + 1) [chromium] › tests/dns-provider-crud.spec.ts:16:5 › DNS Provider CRUD Operations › Create Provider › should create a Manual DNS provider › Save provider -Removed 4 unreachable defensive audit error handlers from `encryption_handler.go`. These handlers checked for audit channel full errors that never occur in tests (channel processes async with 100-item buffer). + Error: expect(locator).not.toBeVisible() failed -### Changes Made + Locator: getByRole('dialog') + Expected: not visible + Received: visible + Timeout: 10000ms -**File**: `backend/internal/api/handlers/encryption_handler.go` -**Lines Modified**: 85, 108, 177, 198 + Call log: + - Expect "not toBeVisible" with timeout 10000ms + - waiting for getByRole('dialog') + 14 × locator resolved to