akanealw/Charon
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(frontend): remove test types from base tsconfig for CI build

Browse Source 
The base tsconfig.json had types: ["vitest/globals", "@testing-library/jest-dom/vitest"]
which are devDependencies only installed during development. CI production
builds with npm ci --production don't include these, causing TS2688 errors.

Solution:

Remove types array from tsconfig.json (let TS auto-discover available types)
Simplify tsconfig.build.json to only exclude test files
Add triple-slash type references to test setup file
Add typecheck config to vitest.config.ts
This ensures:

Production builds work without devDependencies
Test files still have proper type definitions
No JSX.IntrinsicElements errors from missing React types
This commit is contained in:
GitHub Actions
2026-01-25 21:26:47 +00:00
parent 8612aa52e1
commit 0cd93ceb79
18 changed files with 111 additions and 91 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
frontend/src/components/CredentialManager.tsx
View File

@@ -68,11 +68,12 @@ export default function CredentialManager({
toast.success(t('credentials.deleteSuccess', 'Credential deleted successfully'))
setDeleteConfirm(null)
refetch()
} catch (error: any) {
} catch (error: unknown) {
const err = error as { response?: { data?: { error?: string } }; message?: string }
toast.error(
t('credentials.deleteFailed', 'Failed to delete credential') +
': ' +
(error.response?.data?.error || error.message)
(err.response?.data?.error || err.message)
)
}
}
@@ -90,11 +91,12 @@ export default function CredentialManager({
toast.error(result.error || t('credentials.testFailed', 'Credential test failed'))
}
refetch()
} catch (error: any) {
} catch (error: unknown) {
const err = error as { response?: { data?: { error?: string } }; message?: string }
toast.error(
t('credentials.testFailed', 'Failed to test credential') +
': ' +
(error.response?.data?.error || error.message)
(err.response?.data?.error || err.message)
)
} finally {
setTestingId(null)
@@ -367,7 +369,8 @@ function CredentialForm({
}
}
setErrors((prev) => {
const { zone_filter, ...rest } = prev
// eslint-disable-next-line @typescript-eslint/no-unused-vars
const { zone_filter: _, ...rest } = prev
return rest
})
return true
@@ -426,11 +429,12 @@ function CredentialForm({
await createMutation.mutateAsync({ providerId, data })
}
onSuccess()
} catch (error: any) {
} catch (error: unknown) {
const err = error as { response?: { data?: { error?: string } }; message?: string }
toast.error(
t('credentials.saveFailed', 'Failed to save credential') +
': ' +
(error.response?.data?.error || error.message)
(err.response?.data?.error || err.message)
)
}
}
@@ -451,11 +455,12 @@ function CredentialForm({
} else {
toast.error(result.error || t('credentials.testFailed', 'Test failed'))
}
} catch (error: any) {
} catch (error: unknown) {
const err = error as { response?: { data?: { error?: string } }; message?: string }
toast.error(
t('credentials.testFailed', 'Test failed') +
': ' +
(error.response?.data?.error || error.message)
(err.response?.data?.error || err.message)
)
}
}